Skip to content

Commit f88e69f

Browse files
timfeltimfel
committed
[GR-19936] Refactor CallNode to make uncached use easier and a little safer
PullRequest: graalpython/754
2 parents b6bbe48 + e85daaf commit f88e69f

File tree

200 files changed

+3812
-10940
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

200 files changed

+3812
-10940
lines changed

‎ci.jsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{ overlay: "ce65e9108577ef31130e4646ea4e7df0368a6358" }
1+
{ overlay: "88ca31128960b890766c1c6266f62db4e6699c5c" }

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/AssignmentTests/assignment09.tast

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@ ModuleRootNode Name: <module 'assignment09'> SourceSection: [0,9]`f().b = 1`
1212
SetAttributeNodeGen SourceSection: [0,9]`f().b = 1`
1313
Attribute: b
1414
PythonCallNodeGen SourceSection: [0,3]`f()`
15-
CachedCallNodeGen SourceSection: None
16-
CreateArgumentsNodeGen SourceSection: None
17-
CallDispatchNodeGen SourceSection: None
15+
CallNodeGen SourceSection: None
1816
ReadNameNodeGen SourceSection: None
1917
Identifier: f
2018
IntegerLiteralNode SourceSection: [8,9]`1`

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/AwaitAndAsyncTests/asyncWith01.tast

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,8 @@ ModuleRootNode Name: <module 'asyncWith01'> SourceSection: [0,34]`async def f():
4646
LookupAttributeInMRONodeGen SourceSection: None
4747
IsSameTypeNodeGen SourceSection: None
4848
GetLazyClassNodeGen SourceSection: None
49-
CachedCallNodeGen SourceSection: None
50-
CreateArgumentsNodeGen SourceSection: None
51-
CallDispatchNodeGen SourceSection: None
52-
CachedCallNodeGen SourceSection: None
53-
CreateArgumentsNodeGen SourceSection: None
54-
CallDispatchNodeGen SourceSection: None
49+
CallNodeGen SourceSection: None
50+
CallNodeGen SourceSection: None
5551
YesNodeGen SourceSection: None
5652
GetClassNodeGen SourceSection: None
5753
SaveExceptionStateNodeGen SourceSection: None

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/AwaitAndAsyncTests/asyncWith02.tast

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,8 @@ ModuleRootNode Name: <module 'asyncWith02'> SourceSection: [0,47]`async def f():
5252
LookupAttributeInMRONodeGen SourceSection: None
5353
IsSameTypeNodeGen SourceSection: None
5454
GetLazyClassNodeGen SourceSection: None
55-
CachedCallNodeGen SourceSection: None
56-
CreateArgumentsNodeGen SourceSection: None
57-
CallDispatchNodeGen SourceSection: None
58-
CachedCallNodeGen SourceSection: None
59-
CreateArgumentsNodeGen SourceSection: None
60-
CallDispatchNodeGen SourceSection: None
55+
CallNodeGen SourceSection: None
56+
CallNodeGen SourceSection: None
6157
YesNodeGen SourceSection: None
6258
GetClassNodeGen SourceSection: None
6359
SaveExceptionStateNodeGen SourceSection: None
@@ -76,12 +72,8 @@ ModuleRootNode Name: <module 'asyncWith02'> SourceSection: [0,47]`async def f():
7672
LookupAttributeInMRONodeGen SourceSection: None
7773
IsSameTypeNodeGen SourceSection: None
7874
GetLazyClassNodeGen SourceSection: None
79-
CachedCallNodeGen SourceSection: None
80-
CreateArgumentsNodeGen SourceSection: None
81-
CallDispatchNodeGen SourceSection: None
82-
CachedCallNodeGen SourceSection: None
83-
CreateArgumentsNodeGen SourceSection: None
84-
CallDispatchNodeGen SourceSection: None
75+
CallNodeGen SourceSection: None
76+
CallNodeGen SourceSection: None
8577
YesNodeGen SourceSection: None
8678
GetClassNodeGen SourceSection: None
8779
SaveExceptionStateNodeGen SourceSection: None

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/AwaitAndAsyncTests/await01.tast

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ ModuleRootNode Name: <module 'await01'> SourceSection: [0,28]`async def f():↵
3535
BlockNode SourceSection: None
3636
ExpressionStatementNode SourceSection: [16,28]`await smth()`
3737
PythonCallNodeGen SourceSection: [16,28]`await smth()`
38-
CachedCallNodeGen SourceSection: None
39-
CreateArgumentsNodeGen SourceSection: None
40-
CallDispatchNodeGen SourceSection: None
38+
CallNodeGen SourceSection: None
4139
ReadGlobalOrBuiltinNodeGen SourceSection: None
4240
Identifier: smth
4341
ReadAttributeFromObjectNotTypeNodeGen SourceSection: None

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/AwaitAndAsyncTests/await02.tast

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,7 @@ ModuleRootNode Name: <module 'await02'> SourceSection: [0,34]`async def f():↵
3838
WriteLocalFrameSlotNodeGen SourceSection: None
3939
Frame: [0,foo,Illegal]
4040
PythonCallNodeGen SourceSection: [22,34]`await smth()`
41-
CachedCallNodeGen SourceSection: None
42-
CreateArgumentsNodeGen SourceSection: None
43-
CallDispatchNodeGen SourceSection: None
41+
CallNodeGen SourceSection: None
4442
ReadGlobalOrBuiltinNodeGen SourceSection: None
4543
Identifier: smth
4644
ReadAttributeFromObjectNotTypeNodeGen SourceSection: None

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/AwaitAndAsyncTests/await03.tast

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ ModuleRootNode Name: <module 'await03'> SourceSection: [0,39]`async def f():↵
3535
BlockNode SourceSection: None
3636
DestructuringAssignmentNodeGen SourceSection: [16,39]`foo, bar = await smt...`
3737
PythonCallNodeGen SourceSection: [27,39]`await smth()`
38-
CachedCallNodeGen SourceSection: None
39-
CreateArgumentsNodeGen SourceSection: None
40-
CallDispatchNodeGen SourceSection: None
38+
CallNodeGen SourceSection: None
4139
ReadGlobalOrBuiltinNodeGen SourceSection: None
4240
Identifier: smth
4341
ReadAttributeFromObjectNotTypeNodeGen SourceSection: None

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/AwaitAndAsyncTests/await04.tast

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ ModuleRootNode Name: <module 'await04'> SourceSection: [0,30]`async def f():↵
3535
BlockNode SourceSection: None
3636
ExpressionStatementNode SourceSection: [17,29]`await smth()`
3737
PythonCallNodeGen SourceSection: [17,29]`await smth()`
38-
CachedCallNodeGen SourceSection: None
39-
CreateArgumentsNodeGen SourceSection: None
40-
CallDispatchNodeGen SourceSection: None
38+
CallNodeGen SourceSection: None
4139
ReadGlobalOrBuiltinNodeGen SourceSection: None
4240
Identifier: smth
4341
ReadAttributeFromObjectNotTypeNodeGen SourceSection: None

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/AwaitAndAsyncTests/await05.tast

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,9 @@ ModuleRootNode Name: <module 'await05'> SourceSection: [0,35]`async def f():↵
3535
BlockNode SourceSection: None
3636
ExpressionStatementNode SourceSection: [16,35]`foo((await smth()))`
3737
PythonCallNodeGen SourceSection: [16,35]`foo((await smth()))`
38-
CachedCallNodeGen SourceSection: None
39-
CreateArgumentsNodeGen SourceSection: None
40-
CallDispatchNodeGen SourceSection: None
38+
CallNodeGen SourceSection: None
4139
PythonCallNodeGen SourceSection: [21,33]`await smth()`
42-
CachedCallNodeGen SourceSection: None
43-
CreateArgumentsNodeGen SourceSection: None
44-
CallDispatchNodeGen SourceSection: None
40+
CallNodeGen SourceSection: None
4541
ReadGlobalOrBuiltinNodeGen SourceSection: None
4642
Identifier: smth
4743
ReadAttributeFromObjectNotTypeNodeGen SourceSection: None

‎graalpython/com.oracle.graal.python.test/testData/goldenFiles/AwaitAndAsyncTests/await06.tast

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,7 @@ ModuleRootNode Name: <module 'await06'> SourceSection: [0,38]`async def f():↵
3636
BlockNode SourceSection: None
3737
ExpressionStatementNode SourceSection: [16,27]`await foo()`
3838
PythonCallNodeGen SourceSection: [16,27]`await foo()`
39-
CachedCallNodeGen SourceSection: None
40-
CreateArgumentsNodeGen SourceSection: None
41-
CallDispatchNodeGen SourceSection: None
39+
CallNodeGen SourceSection: None
4240
ReadGlobalOrBuiltinNodeGen SourceSection: None
4341
Identifier: foo
4442
ReadAttributeFromObjectNotTypeNodeGen SourceSection: None

0 commit comments

Comments
 (0)