support follow_symlinks keyword arg in is_dir

Author: timfel

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/posix/DirEntryBuiltins.java

@@ -40,6 +40,7 @@
  */
 package com.oracle.graal.python.builtins.objects.posix;
 
+import java.nio.file.LinkOption;
 import java.util.List;
 
 import com.oracle.graal.python.builtins.Builtin;
@@ -51,7 +52,9 @@
 import com.oracle.graal.python.nodes.SpecialMethodNames;
 import com.oracle.graal.python.nodes.attributes.ReadAttributeFromObjectNode;
 import com.oracle.graal.python.nodes.attributes.WriteAttributeToObjectNode;
+import com.oracle.graal.python.nodes.expression.CastToBooleanNode;
 import com.oracle.graal.python.nodes.function.PythonBuiltinBaseNode;
+import com.oracle.graal.python.nodes.function.builtins.PythonBinaryBuiltinNode;
 import com.oracle.graal.python.nodes.function.builtins.PythonUnaryBuiltinNode;
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.dsl.Cached;
@@ -62,6 +65,9 @@
 @CoreFunctions(extendClasses = PythonBuiltinClassType.PDirEntry)
 public class DirEntryBuiltins extends PythonBuiltins {
 
+    private static final LinkOption[] NOFOLLOW_LINKS_OPTIONS = new LinkOption[]{LinkOption.NOFOLLOW_LINKS};
+    private static final LinkOption[] NO_LINK_OPTIONS = new LinkOption[0];
+
     @Override
     protected List<? extends NodeFactory<? extends PythonBuiltinBaseNode>> getNodeFactories() {
         return DirEntryBuiltinsFactory.getFactories();
@@ -95,6 +101,10 @@ PNone inode(@SuppressWarnings("unused") PDirEntry self) {
         }
     }
 
+    private static LinkOption[] getLinkOption(boolean followSymlinks) {
+        return followSymlinks ? NO_LINK_OPTIONS : NOFOLLOW_LINKS_OPTIONS;
+    }
+
     @Builtin(name = "is_symlink", minNumOfPositionalArgs = 1)
     @GenerateNodeFactory
     abstract static class IsSymNode extends PythonUnaryBuiltinNode {
@@ -104,12 +114,27 @@ boolean test(PDirEntry self) {
         }
     }
 
-    @Builtin(name = "is_dir", minNumOfPositionalArgs = 1)
+    @Builtin(name = "is_dir", minNumOfPositionalArgs = 1, keywordOnlyNames = {"follow_symlinks"})
     @GenerateNodeFactory
-    abstract static class IsDirNode extends PythonUnaryBuiltinNode {
+    abstract static class IsDirNode extends PythonBinaryBuiltinNode {
         @Specialization
-        boolean test(PDirEntry self) {
-            return self.getFile().isDirectory();
+        boolean testBool(PDirEntry self, boolean followSymlinks) {
+            return self.getFile().isDirectory(getLinkOption(followSymlinks));
+        }
+
+        @Specialization
+        boolean testNone(PDirEntry self, @SuppressWarnings("unused") PNone followSymlinks) {
+            return testBool(self, true);
+        }
+
+        @Specialization
+        boolean testAny(Object self, Object followSymlinks,
+                        @Cached("createIfTrueNode()") CastToBooleanNode isTrue) {
+            if (self instanceof PDirEntry) {
+                return testBool((PDirEntry) self, isTrue.executeWith(followSymlinks));
+            } else {
+                throw raise(PythonBuiltinClassType.TypeError, "descriptor 'is_dir' requires a 'posix.DirEntry' object but received a '%p'", self);
+            }
         }
     }