Treat compiler warnings as errors in our C projects

Author: steve-s

graalpython/com.oracle.graal.python.cext/CMakeLists.txt

@@ -28,6 +28,7 @@
 #
 cmake_minimum_required(VERSION 3.22)
 project(com.oracle.graal.python.cext)
+set(CMAKE_COMPILE_WARNING_AS_ERROR ON)
 
 function(require_var var)
     if (NOT DEFINED ${var})

graalpython/com.oracle.graal.python.cext/src/capi.c

@@ -251,7 +251,7 @@ PyAPI_FUNC(void) mmap_init_bufferprotocol(PyObject* mmap_type) {
 	    (getbufferproc)mmap_getbuffer,
 	    (releasebufferproc)NULL,
 	};
-	GraalPy_set_PyTypeObject_tp_as_buffer(mmap_type, &mmap_as_buffer);
+	GraalPy_set_PyTypeObject_tp_as_buffer((PyTypeObject *) mmap_type, &mmap_as_buffer);
 	((PyTypeObject*) mmap_type)->tp_as_buffer = &mmap_as_buffer;
 }
 
@@ -268,7 +268,7 @@ PyAPI_FUNC(void) PyTruffleCData_InitBufferProtocol(PyObject* type) {
         cdata_getbuffer,
         cdata_releasebuffer,
     };
-    GraalPy_set_PyTypeObject_tp_as_buffer(type, &cdata_as_buffer);
+    GraalPy_set_PyTypeObject_tp_as_buffer(((PyTypeObject*) type), &cdata_as_buffer);
     ((PyTypeObject*) type)->tp_as_buffer = &cdata_as_buffer;
 }
 
@@ -309,7 +309,7 @@ void memory_releasebuf(PyMemoryViewObject *self, Py_buffer *view);
 static int
 picklebuf_getbuf(PyPickleBufferObject *self, Py_buffer *view, int flags)
 {
-    PyObject *self_view_obj = GraalPyTruffle_PickleBuffer_viewobj(self);
+    PyObject *self_view_obj = GraalPyTruffle_PickleBuffer_viewobj((PyObject*) self);
     return PyObject_GetBuffer(self_view_obj, view, flags);
 }
 

graalpython/com.oracle.graal.python.hpy.llvm/CMakeLists.txt

@@ -28,6 +28,7 @@
 #
 cmake_minimum_required(VERSION 3.22)
 project(com.oracle.graal.python.hpy.llvm)
+set(CMAKE_COMPILE_WARNING_AS_ERROR ON)
 
 function(require_var var)
   if (NOT DEFINED ${var})

graalpython/com.oracle.graal.python.hpy.llvm/src/autogen_c_access.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2023, 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -61,7 +61,7 @@
 static int fill_c_type_sizes(int32_t *ctype_sizes)
 {
     ctype_sizes[0] = (int32_t) sizeof(HPyContext*);
-    ctype_sizes[1] = (int32_t) sizeof(void);
+    ctype_sizes[1] = (int32_t) 0;
     ctype_sizes[2] = (int32_t) sizeof(void*);
     ctype_sizes[3] = (int32_t) sizeof(void**);
     ctype_sizes[4] = (int32_t) sizeof(bool);

graalpython/com.oracle.graal.python.jni/src/ctx_call_jni.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2023, 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -69,7 +69,7 @@ JNIEXPORT jlong JNICALL TRAMPOLINE(executeDebugKeywords)(JNIEnv *env, jclass cla
     }
     assert(nargs >= 0);
     assert(n_kwnames >= 0);
-    size_t nargs_with_kw = (size_t)nargs + (size_t)n_kwnames;
+    jlong nargs_with_kw = nargs + n_kwnames;
     _ARR_JLONG2DH(dctx, dh_args, args, nargs_with_kw)
     DHPy dh_result = f(dctx, dh_self, dh_args, (size_t)nargs, dh_kwnames);
     _ARR_DH_CLOSE(dctx, dh_args, nargs_with_kw)

graalpython/com.oracle.graal.python.jni/src/debug/debug_ctx.c

@@ -1,6 +1,6 @@
 /* MIT License
  *
- * Copyright (c) 2022, 2023, Oracle and/or its affiliates.
+ * Copyright (c) 2022, 2024, Oracle and/or its affiliates.
  * Copyright (c) 2019 pyhandle
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
@@ -31,12 +31,6 @@
 # include <malloc.h>   /* for alloca() */
 #endif
 
-static struct _HPyContext_s g_debug_ctx = {
-    .name = "HPy Debug Mode ABI",
-    ._private = NULL,
-    .abi_version = HPY_ABI_VERSION,
-};
-
 static HPyDebugCtxInfo *init_ctx_info(HPyContext *dctx, HPyContext *uctx) {
     HPyDebugCtxInfo *ctx_info = (HPyDebugCtxInfo*) malloc(sizeof(HPyDebugCtxInfo));
     if (ctx_info == NULL) {

graalpython/com.oracle.graal.python.jni/src/hpy_jni.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2021, 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * The Universal Permissive License (UPL), Version 1.0
@@ -146,20 +146,6 @@ static uint64_t get_hpy_handle_for_object(HPyContext *ctx, jobject hpyContext, j
     return boxHandle(next_handle);
 }
 
-static jobject get_object_for_hpy_handle(jobject hpyContext, uint64_t bits) {
-    jobjectArray hpy_handles = (jobjectArray)(*jniEnv)->GetObjectField(jniEnv, hpyContext, jniField_hpyHandleTable);
-    if (hpy_handles == NULL) {
-        LOGS("hpy handle table is NULL")
-        return NULL;
-    }
-    jobject element = (*jniEnv)->GetObjectArrayElement(jniEnv, (jobjectArray)hpy_handles, (jsize)unboxHandle(bits));
-    (*jniEnv)->DeleteLocalRef(jniEnv, hpy_handles);
-    if (element == NULL) {
-        LOGS("handle delegate is NULL")
-    }
-    return element;
-}
-
 static jobject get_object_for_hpy_global(jobject hpyContext, uint64_t bits) {
     jobject hpy_globals = (*jniEnv)->GetObjectField(jniEnv, hpyContext, jniField_hpyGlobalsTable);
     if (hpy_globals == NULL) {

graalpython/com.oracle.graal.python.jni/src/hpy_native_fast_paths.c

@@ -44,6 +44,7 @@
 #include "hpy_native_fast_paths.h"
 #include "hpy_native_cache.h"
 
+#include <assert.h>
 #include <stdint.h>
 
 #define MAX_UNCLOSED_HANDLES 32
@@ -53,15 +54,20 @@ static HPy unclosedHandles[MAX_UNCLOSED_HANDLES];
 //*************************
 // BOXING
 
+static_assert(sizeof(uint64_t) == sizeof(double), "Assumption necessary for NaN boxing to work");
+
 static inline double unboxDouble(uint64_t value) {
-    uint64_t doubleBits = value - NAN_BOXING_BASE;
-    return * ((double*) &doubleBits);
+    double result;
+    uint64_t unboxed = value - NAN_BOXING_BASE;
+    memcpy(&result, &unboxed, sizeof(double));
+    return result;
 }
 
 static inline uint64_t boxDouble(double value) {
     // assumes that value doesn't contain non-standard silent NaNs
-    uint64_t doubleBits = * ((uint64_t*) &value);
-    return doubleBits + NAN_BOXING_BASE;
+    uint64_t unboxed;
+    memcpy(&unboxed, &value, sizeof(double));
+    return unboxed + NAN_BOXING_BASE;
 }
 
 //*************************

graalpython/com.oracle.graal.python.jni/src/trace/_tracemod.c

@@ -1,6 +1,6 @@
 /* MIT License
  *
- * Copyright (c) 2023, 2023, Oracle and/or its affiliates.
+ * Copyright (c) 2023, 2024, Oracle and/or its affiliates.
  * Copyright (c) 2019 pyhandle
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
@@ -179,7 +179,7 @@ get_optional_arg(HPyContext *ctx, const HPy *args, size_t nargs, HPy kwnames,
     HPy_ssize_t nkw, j;
     HPy h_kwname, h_item;
     // if given as positional arg
-    if (i < nargs) {
+    if (i < (HPy_ssize_t) nargs) {
         *out = args[i];
         return 0;
     }

graalpython/com.oracle.graal.python.jni/src/trace/trace_ctx.c

@@ -1,6 +1,6 @@
 /* MIT License
  *
- * Copyright (c) 2023, 2023, Oracle and/or its affiliates.
+ * Copyright (c) 2023, 2024, Oracle and/or its affiliates.
  * Copyright (c) 2019 pyhandle
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
@@ -25,12 +25,6 @@
 #include "trace_internal.h"
 #include "autogen_trace_ctx_init.h"
 
-static struct _HPyContext_s g_trace_ctx = {
-    .name = "HPy Trace Mode ABI",
-    ._private = NULL,
-    .abi_version = HPY_ABI_VERSION,
-};
-
 // NOTE: at the moment this function assumes that uctx is always the
 // same. If/when we migrate to a system in which we can have multiple
 // independent contexts, this function should ensure to create a different