Add missing fallback

msimacek · msimacek · commit fab13360a779 · 2023-05-26T11:15:21.000+02:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/cext/PythonCextUnicodeBuiltins.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/cext/PythonCextUnicodeBuiltins.java
@@ -875,7 +875,7 @@ public static _PyUnicode_AsUTF8String create() {
     abstract static class PyTruffle_Unicode_AsUTF8AndSize_CharPtr extends CApiUnaryBuiltinNode {
 
         @Specialization
-        Object doUnicode(PString s,
+        static Object doUnicode(PString s,
                         @Bind("this") Node inliningTarget,
                         @Cached InlinedConditionProfile profile,
                         @Cached _PyUnicode_AsUTF8String asUTF8String) {
@@ -885,6 +885,11 @@ Object doUnicode(PString s,
             }
             return new PySequenceArrayWrapper(s.getUtf8Bytes(), 1);
         }
+
+        @Fallback
+        Object doError(@SuppressWarnings("unused") Object s) {
+            throw raise(TypeError, BAD_ARG_TYPE_FOR_BUILTIN_OP);
+        }
     }
 
     @CApiBuiltin(ret = Py_ssize_t, args = {PyObject}, call = Direct)
@@ -912,6 +917,11 @@ Object doUnicode(PString s,
             }
             return new PySequenceArrayWrapper(s.getWCharBytes(), 1);
         }
+
+        @Fallback
+        Object doError(@SuppressWarnings("unused") Object s) {
+            throw raise(TypeError, BAD_ARG_TYPE_FOR_BUILTIN_OP);
+        }
     }
 
     @CApiBuiltin(ret = Py_ssize_t, args = {PyObject}, call = Direct)

Original file line number	Diff line number	Diff line change
`@@ -875,7 +875,7 @@ public static _PyUnicode_AsUTF8String create() {`
`875`	`875`	`abstract static class PyTruffle_Unicode_AsUTF8AndSize_CharPtr extends CApiUnaryBuiltinNode {`
`876`	`876`
`877`	`877`	`@Specialization`
`878`		`- Object doUnicode(PString s,`
	`878`	`+ static Object doUnicode(PString s,`
`879`	`879`	`@Bind("this") Node inliningTarget,`
`880`	`880`	`@Cached InlinedConditionProfile profile,`
`881`	`881`	`@Cached _PyUnicode_AsUTF8String asUTF8String) {`
`@@ -885,6 +885,11 @@ Object doUnicode(PString s,`
`885`	`885`	`}`
`886`	`886`	`return new PySequenceArrayWrapper(s.getUtf8Bytes(), 1);`
`887`	`887`	`}`
	`888`	`+`
	`889`	`+ @Fallback`
	`890`	`+ Object doError(@SuppressWarnings("unused") Object s) {`
	`891`	`+ throw raise(TypeError, BAD_ARG_TYPE_FOR_BUILTIN_OP);`
	`892`	`+ }`
`888`	`893`	`}`
`889`	`894`
`890`	`895`	`@CApiBuiltin(ret = Py_ssize_t, args = {PyObject}, call = Direct)`
`@@ -912,6 +917,11 @@ Object doUnicode(PString s,`
`912`	`917`	`}`
`913`	`918`	`return new PySequenceArrayWrapper(s.getWCharBytes(), 1);`
`914`	`919`	`}`
	`920`	`+`
	`921`	`+ @Fallback`
	`922`	`+ Object doError(@SuppressWarnings("unused") Object s) {`
	`923`	`+ throw raise(TypeError, BAD_ARG_TYPE_FOR_BUILTIN_OP);`
	`924`	`+ }`
`915`	`925`	`}`
`916`	`926`
`917`	`927`	`@CApiBuiltin(ret = Py_ssize_t, args = {PyObject}, call = Direct)`