avoid invoke when splatting a PList

Author: timfel

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/common/SequenceStorageNodes.java

@@ -3296,7 +3296,7 @@ public ToArrayNode(boolean exact) {
         @Specialization
         Object[] doObjectSequenceStorage(ObjectSequenceStorage s) {
             Object[] barr = s.getInternalArray();
-            if (exact) {
+            if (exact && barr.length != s.length()) {
                 return exactCopy(barr, s.length());
             }
             return barr;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/argument/positional/ExecutePositionalStarargsNode.java

@@ -44,6 +44,7 @@
 import java.util.Iterator;
 
 import com.oracle.graal.python.builtins.objects.PNone;
+import com.oracle.graal.python.builtins.objects.common.SequenceStorageNodes;
 import com.oracle.graal.python.builtins.objects.dict.PDict;
 import com.oracle.graal.python.builtins.objects.list.PList;
 import com.oracle.graal.python.builtins.objects.set.PSet;
@@ -81,13 +82,9 @@ static Object[] starargs(PTuple starargs) {
     }
 
     @Specialization
-    static Object[] starargs(PList starargs) {
-        int length = starargs.getSequenceStorage().length();
-        Object[] internalArray = starargs.getSequenceStorage().getInternalArray();
-        if (internalArray.length != length) {
-            return starargs.getSequenceStorage().getCopyOfInternalArray();
-        }
-        return internalArray;
+    static Object[] starargs(PList starargs,
+                    @Cached SequenceStorageNodes.ToArrayNode toArray) {
+        return toArray.execute(starargs.getSequenceStorage());
     }
 
     @Specialization
@@ -170,7 +167,12 @@ static Object[] starargs(PTuple starargs) {
 
         @Specialization
         static Object[] starargs(PList starargs) {
-            return ExecutePositionalStarargsNode.starargs(starargs);
+            int length = starargs.getSequenceStorage().length();
+            Object[] internalArray = starargs.getSequenceStorage().getInternalArray();
+            if (internalArray.length != length) {
+                return starargs.getSequenceStorage().getCopyOfInternalArray();
+            }
+            return internalArray;
         }
 
         @Specialization