Skip to content

Commit fcb2f7a

Browse files
committed
Fix unused import warning in clinic-generated code
1 parent 8ba6b81 commit fcb2f7a

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

graalpython/com.oracle.graal.python.processor/src/com/oracle/graal/python/processor/ArgumentClinicProcessor.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@
4040
*/
4141
package com.oracle.graal.python.processor;
4242

43+
import static com.oracle.graal.python.processor.ConverterFactory.CLINIC_PACKAGE;
44+
4345
import java.io.IOException;
4446
import java.time.LocalDateTime;
4547
import java.util.ArrayList;
@@ -77,8 +79,6 @@
7779
import com.oracle.graal.python.processor.ArgumentClinicModel.BuiltinClinicData;
7880
import com.oracle.graal.python.processor.CodeWriter.Block;
7981

80-
import static com.oracle.graal.python.processor.ConverterFactory.CLINIC_PACKAGE;
81-
8282
public class ArgumentClinicProcessor extends AbstractProcessor {
8383
private static final boolean LOGGING = false;
8484
private static final String BuiltinAnnotationClass = "com.oracle.graal.python.builtins.Builtin";
@@ -148,12 +148,14 @@ private void writeCode(HashMap<TypeElement, Set<BuiltinClinicData>> enclosingTyp
148148
private void writeImports(CodeWriter w, Entry<TypeElement, Set<BuiltinClinicData>> enclosingType) throws IOException {
149149
log("Writing imports...");
150150
TreeSet<String> imports = new TreeSet<>();
151-
imports.add("com.oracle.graal.python.nodes.function.PythonBuiltinBaseNode");
152151
imports.add(CLINIC_PACKAGE + ".ArgumentClinicProvider");
153-
imports.add(CLINIC_PACKAGE + ".ArgumentCastNode");
154152
for (BuiltinClinicData builtin : enclosingType.getValue()) {
155153
for (ArgumentClinicData arg : builtin.arguments) {
156154
imports.addAll(arg.imports);
155+
if (arg.castNodeFactory != null) {
156+
imports.add("com.oracle.graal.python.nodes.function.PythonBuiltinBaseNode");
157+
imports.add(CLINIC_PACKAGE + ".ArgumentCastNode");
158+
}
157159
}
158160
}
159161
for (String pkg : imports) {

0 commit comments

Comments
 (0)