[GR-47378] Compare bytes as unsigned bytes

ppisl · ppisl · commit fdf52a379cc9 · 2023-07-13T17:33:22.000+02:00
diff --git a/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/bytes/BytesNodes.java b/graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/bytes/BytesNodes.java
@@ -972,7 +972,7 @@ protected boolean doCmp(byte[] selfArray, int selfLength, byte[] otherArray, int
                 return shortcutLengthResult();
             }
             for (int i = 0; i < Math.min(selfLength, otherLength); i++) {
-                compareResult = Byte.compare(selfArray[i], otherArray[i]);
+                compareResult = Integer.compare(Byte.toUnsignedInt(selfArray[i]), Byte.toUnsignedInt(otherArray[i]));
                 if (compareResult != 0) {
                     break;
                 }

Original file line number	Diff line number	Diff line change
`@@ -972,7 +972,7 @@ protected boolean doCmp(byte[] selfArray, int selfLength, byte[] otherArray, int`
`972`	`972`	`return shortcutLengthResult();`
`973`	`973`	`}`
`974`	`974`	`for (int i = 0; i < Math.min(selfLength, otherLength); i++) {`
`975`		`- compareResult = Byte.compare(selfArray[i], otherArray[i]);`
	`975`	`+ compareResult = Integer.compare(Byte.toUnsignedInt(selfArray[i]), Byte.toUnsignedInt(otherArray[i]));`
`976`	`976`	`if (compareResult != 0) {`
`977`	`977`	`break;`
`978`	`978`	`}`