Skip to content

Commit 196e8a3

Browse files
wilkinsonavjovanov
authored andcommitted
Correct type reachable condition in Quartz resource config
fe74d0e added a type reachable condition for Quartz's SQL resource files but the type that was used (org.quartz.SimpleJob) isn't part of Quartz and only exists in the tests for the Quartz metadata. This commit updates the tests to reveal the problem by moving their classes out of the org.quartz namespace and updates the metadata to use a type in the condition that's part of Quartz.
1 parent 3a8164b commit 196e8a3

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

metadata/org.quartz-scheduler/quartz/2.3.2/resource-config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
{
55
"pattern": "\\Qorg/quartz/impl/jdbcjobstore/tables_\\E.*\\Q.sql\\E",
66
"condition": {
7-
"typeReachable": "org.quartz.SimpleJob"
7+
"typeReachable": "org.quartz.impl.StdSchedulerFactory"
88
}
99
},
1010
{

tests/src/org.quartz-scheduler/quartz/2.3.2/src/test/java/org/quartz/QuartzTest.java renamed to tests/src/org.quartz-scheduler/quartz/2.3.2/src/test/java/quartz/QuartzTest.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,19 @@
44
* You should have received a copy of the CC0 legalcode along with this
55
* work. If not, see <http://creativecommons.org/publicdomain/zero/1.0/>.
66
*/
7-
package org.quartz;
7+
package quartz;
88

99
import java.io.InputStream;
1010
import java.util.Properties;
1111

1212
import org.junit.jupiter.api.Test;
13+
import org.quartz.JobBuilder;
14+
import org.quartz.JobDetail;
15+
import org.quartz.Scheduler;
16+
import org.quartz.SchedulerException;
17+
import org.quartz.SimpleScheduleBuilder;
18+
import org.quartz.Trigger;
19+
import org.quartz.TriggerBuilder;
1320
import org.quartz.impl.StdSchedulerFactory;
1421
import org.quartz.simpl.SimpleThreadPool;
1522

tests/src/org.quartz-scheduler/quartz/2.3.2/src/test/java/org/quartz/SimpleJob.java renamed to tests/src/org.quartz-scheduler/quartz/2.3.2/src/test/java/quartz/SimpleJob.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
* You should have received a copy of the CC0 legalcode along with this
55
* work. If not, see <http://creativecommons.org/publicdomain/zero/1.0/>.
66
*/
7-
package org.quartz;
7+
package quartz;
8+
9+
import org.quartz.Job;
10+
import org.quartz.JobExecutionContext;
811

912
public class SimpleJob implements Job {
1013

0 commit comments

Comments
 (0)