New and unexecuted cells will not display success or failure

Author: subhash-arabhi

vscode/src/notebooks/codeCellExecution.ts

@@ -33,7 +33,7 @@ export class CodeCellExecution {
         diagnostics: string[] | undefined,
         errorDiagnostics: string[] | undefined,
         metadata: any,
-        executionOrder: number) => {
+        executionOrder: number | undefined) => {
 
         if (!this.isExecutionStarted) {
             this.handleExecutionStart(executionOrder);
@@ -98,7 +98,7 @@ export class CodeCellExecution {
         }
     }
 
-    private handleExecutionStart = async (executionOrder: number) => {
+    private handleExecutionStart = async (executionOrder: number | undefined) => {
         if (this.controller) {
             this.execution = this.controller.createNotebookCellExecution(this.cell);
             this.isExecutionStarted = true;

vscode/src/notebooks/kernel.ts

@@ -156,7 +156,7 @@ export class IJNBKernel implements Disposable {
   }
 
   private getExecutionCounter = (notebookId: string) => {
-    return IJNBKernel.executionCounter.get(notebookId) ?? 1;
+    return IJNBKernel.executionCounter.get(notebookId);
   }
 
   private handleMarkdownCellExecution = async (notebookId: string, cell: NotebookCell, controller: NotebookController) => {

vscode/src/notebooks/utils.ts

@@ -84,10 +84,12 @@ export function parseCell(cell: ICell): vscode.NotebookCellData {
       (cell.metadata as IMetadata).executionSummary,
       cell.execution_count ?? null
     );
-    cellData.executionSummary = {
-      executionOrder: execSummary.executionOrder ?? undefined,
-      success: execSummary.success,
-    };
+    if (execSummary.executionOrder) {
+      cellData.executionSummary = {
+        executionOrder: execSummary.executionOrder ?? undefined,
+        success: execSummary.success,
+      };
+    }
 
     if (Array.isArray(cell.outputs)) {
       const outputs = cell.outputs.flatMap((out: IOutput) => {
@@ -148,10 +150,10 @@ export function serializeCell(cell: vscode.NotebookCellData): ICell {
   if (cell.kind === vscode.NotebookCellKind.Code) {
     const exec = cell.executionSummary ?? {};
     const executionCount = exec.executionOrder ?? null;
-    const success = exec.success ?? false;
+    const success = exec.success;
 
     const execSummary = new ExecutionSummary(executionCount, success);
-    const metadata = { ...baseMeta, executionSummary: execSummary.toJSON()};
+    const metadata = executionCount ? { ...baseMeta, executionSummary: execSummary.toJSON() } : {};
 
     const outputs: IOutput[] = (cell.outputs || []).map((output): IOutput => {
       const data: IMimeBundle = {};