fixed issue of command truncation

Author: Achal1607

nbcode/notebooks/src/org/netbeans/modules/nbcode/java/notebook/NotebookUtils.java

@@ -108,7 +108,7 @@ public static boolean checkEmptyString(String input) {
 
     @SuppressWarnings("unchecked")
     public static <T> T getArgument(List<Object> arguments, int index, Class<T> type) {
-        if (arguments.size() > index && arguments.get(index) != null) {
+        if (arguments != null && arguments.size() > index && arguments.get(index) != null) {
             Object arg = arguments.get(index);
 
             if (arg instanceof JsonElement) {

nbcode/notebooks/src/org/netbeans/modules/nbcode/java/project/CommandHandler.java

@@ -24,6 +24,7 @@
 import org.netbeans.api.project.FileOwnerQuery;
 import org.netbeans.api.project.Project;
 import org.netbeans.modules.java.lsp.server.Utils;
+import org.netbeans.modules.nbcode.java.notebook.NotebookUtils;
 import org.openide.filesystems.FileObject;
 import org.openide.util.Exceptions;
 
@@ -39,16 +40,14 @@ public static CompletableFuture<List<String>> openJshellInProjectContext(List<Ob
         CompletableFuture<List<String>> future = new CompletableFuture<>();
 
         LOG.log(Level.FINER, "Request received for opening Jshell instance with project context {0}", args);
-
-        final String uri = args != null && args.get(0) != null && args.get(0) instanceof JsonPrimitive
-                ? ((JsonPrimitive) args.get(0)).getAsString()
-                : null;
 
+        String uri = NotebookUtils.getArgument(args, 0, String.class);
+
         if (uri == null) {
             future.completeExceptionally(new IllegalArgumentException("uri is required. It cannot be null"));
             return future;
         }
-        
+
         Project prj = getProject(uri);
         if (prj != null) {
             return ProjectConfigurationUtils.buildProject(prj)
@@ -71,19 +70,15 @@ public static CompletableFuture<List<String>> openJshellInProjectContext(List<Ob
     }
 
     public static boolean openNotebookInProjectContext(List<Object> args) {
-        LOG.log(Level.FINER, "Request received for opening Jshell instance with project context {0}", args);
+        LOG.log(Level.FINER, "Request received for opening notebook with project context {0}", args);
 
-        String uri = null, notebookUri = null;
-        if (args != null && !args.isEmpty() && args.get(0) != null && args.get(0) instanceof JsonPrimitive) {
-            uri = ((JsonPrimitive) args.get(0)).getAsString();
-        }
-        if (args != null && args.size() > 1 && args.get(1) != null && args.get(1) instanceof JsonPrimitive) {
-            notebookUri = ((JsonPrimitive) args.get(1)).getAsString();
-        }
+        String uri = NotebookUtils.getArgument(args, 0, String.class);
+        String notebookUri = NotebookUtils.getArgument(args, 1, String.class);
+        
         Project prj = getProject(uri);
         if (prj != null) {
             List<String> remoteVmOptions = ProjectConfigurationUtils.launchVMOptions(prj);
-            List<String> compileOptions = ProjectConfigurationUtils.compileOptions(prj);
+            List<String> compileOptions = ProjectConfigurationUtils.compilerOptions(prj);
 
             LOG.log(Level.INFO, "Opened Notebook instance with project context {0}", uri);
             return true;

nbcode/notebooks/src/org/netbeans/modules/nbcode/java/project/ProjectConfigurationUtils.java

@@ -142,7 +142,7 @@ public static List<String> launchVMOptions(Project project) {
     }
 
     @NonNull
-    public static List<String> compileOptions(Project project) {
+    public static List<String> compilerOptions(Project project) {
         if (project == null) {
             return new ArrayList<>();
         }

nbcode/notebooks/src/org/netbeans/modules/nbcode/java/project/ProjectModulePathConfigurationUtils.java

@@ -251,7 +251,6 @@ public static List<String> getVmOptions(Project project) {
             ));
 
             vmOptions.addAll(getModuleConfigurations(project));
-            
         }
 
         return vmOptions;

vscode/src/commands/notebook.ts

@@ -119,11 +119,15 @@ const openJshellInContextOfProject = async (ctx: any) => {
         let client: LanguageClient = await globalState.getClientPromise().client;
         if (await isNbCommandRegistered(nbCommands.openJshellInProject)) {
             const res: string[] = await commands.executeCommand(nbCommands.openJshellInProject, getContextUri(ctx)?.toString());
-
-            const args = res.join(" ");
-            const terminal = window.createTerminal("Jshell instance");
+            const { envMap, finalArgs } = passArgsToTerminal(res);
+            // Direct sendText is not working since it truncates the command exceeding a certain length.
+            // Open issues on vscode: 130688, 134324 and many more
+            // So, workaround by setting env variables.
+            const terminal = window.createTerminal({
+                name: "Jshell instance", env: envMap
+            });
+            terminal.sendText(`jshell ${finalArgs.join(' ')}`, true);
             terminal.show();
-            terminal.sendText(`jshell ${args}`, true);
         } else {
             throw l10n.value("jdk.extension.error_msg.doesntSupportGoToTest", { client });
         }
@@ -133,6 +137,18 @@ const openJshellInContextOfProject = async (ctx: any) => {
     }
 }
 
+const passArgsToTerminal = (args: string[]): { envMap: { [key: string]: string }, finalArgs: string[] } => {
+    const envMap: { [key: string]: string } = {};
+    const finalArgs = args.map((arg, index) => {
+        if (arg.startsWith('-') || arg.startsWith('--')) {
+            return arg;
+        }
+        const envName = `jshellArgsEnv${index}`;
+        envMap[envName] = arg;
+        return `$${envName}`;
+    });
+    return { envMap, finalArgs };
+}
 
 export const registerNotebookCommands: ICommand[] = [
     {