Skip to content

Commit 9bb62fa

Browse files
committed
Merge branch 'merge_main_20250826' into 'main'
Merge 'oracle:main' as on 2025-08-26 See merge request oci-jpg-jvsce/javavscode-cpu!3
2 parents 04ce72f + 00659e3 commit 9bb62fa

File tree

8 files changed

+221
-94
lines changed

8 files changed

+221
-94
lines changed

build.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@
6464
patches/8460-draft.diff
6565
patches/8470.diff
6666
patches/8484.diff
67+
patches/8745-draft.diff
6768
patches/disable-error-notification.diff
6869
patches/mvn-sh.diff
6970
patches/project-marker-jdk.diff

nbcode/integration/src/org/netbeans/modules/nbcode/integration/LspJavaPlatformProviderOverride.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,8 @@
2828
*/
2929
@ServiceProvider(service = JavaPlatformProvider.class, position = 10_000)
3030
public class LspJavaPlatformProviderOverride extends AbstractJavaPlatformProviderOverride {
31+
32+
public LspJavaPlatformProviderOverride() {
33+
super(System.getProperty("netbeans.lsp.java.platform.override", null)); //NOI18N
34+
}
3135
}

nbcode/telemetry/src/org/netbeans/modules/nbcode/java/lsp/server/telemetry/SourceInfo.java

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,10 @@
2020
import java.lang.ref.WeakReference;
2121
import java.net.URI;
2222
import java.util.Map;
23+
import java.util.concurrent.ExecutionException;
2324
import java.util.function.Function;
25+
import java.util.logging.Level;
26+
import java.util.logging.Logger;
2427
import javax.tools.JavaFileObject;
2528
import javax.tools.SimpleJavaFileObject;
2629
import org.eclipse.lsp4j.services.LanguageClient;
@@ -38,7 +41,7 @@
3841
import org.openide.util.Lookup;
3942

4043
class SourceInfo {
41-
44+
private static final Logger LOG = Logger.getLogger(SourceInfo.class.getName());
4245
private final FileObject file;
4346
private final Project owner;
4447
final JavaFileObject source;
@@ -108,10 +111,15 @@ public String getJavaVersion() {
108111
return LspServerTelemetryManager.getJavaRuntimeVersion(lookupFunction);
109112
}
110113

111-
public boolean getPreviewEnabled() {
112-
return LspServerTelemetryManager.getInstance().isPreviewEnabled(file,
113-
owner == null ? LspServerTelemetryManager.ProjectType.standalone : LspServerTelemetryManager.getInstance().getProjectType(owner),
114-
getLanguageClient());
114+
public boolean getPreviewEnabled(){
115+
try {
116+
return LspServerTelemetryManager.getInstance().isPreviewEnabled(file,
117+
owner,
118+
getLanguageClient()).get();
119+
} catch (InterruptedException | ExecutionException ex) {
120+
LOG.log(Level.FINE, "exception while checking if preview enabled: {0}", (Object) ex);
121+
}
122+
return false;
115123
}
116124

117125
public static SourceInfo getSourceObject(ErrorProvider.Context context) {

patches/8745-draft.diff

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
diff --git a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/ui/AbstractJavaPlatformProviderOverride.java b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/ui/AbstractJavaPlatformProviderOverride.java
2+
index df668954dd..054f85d0e5 100644
3+
--- a/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/ui/AbstractJavaPlatformProviderOverride.java
4+
+++ b/java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/ui/AbstractJavaPlatformProviderOverride.java
5+
@@ -39,6 +39,14 @@ public abstract class AbstractJavaPlatformProviderOverride implements JavaPlatfo
6+
private final PropertyChangeSupport pcs = new PropertyChangeSupport(this);
7+
private FileObject defaultPlatformOverride;
8+
9+
+ public AbstractJavaPlatformProviderOverride() {
10+
+ this(null);
11+
+ }
12+
+
13+
+ protected AbstractJavaPlatformProviderOverride(String defaultPlatformOverride) {
14+
+ this.defaultPlatformOverride = defaultPlatformOverride == null ? null : FileUtil.toFileObject(new File(defaultPlatformOverride));
15+
+ }
16+
+
17+
@Override
18+
@SuppressWarnings("ReturnOfCollectionOrArrayField")
19+
public JavaPlatform[] getInstalledPlatforms() {

patches/nb-telemetry.diff

Lines changed: 157 additions & 88 deletions
Large diffs are not rendered by default.

vscode/CHANGELOG.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,24 @@
2222
under the License.
2323
2424
-->
25+
## Version 24.1.1
26+
### What's Changed
27+
28+
#### Bug Fixes
29+
* Standalone run output correction [#448](https://github.com/oracle/javavscode/pull/448)
30+
* Fix run/debug/test due to launch-config clashes [#432](https://github.com/oracle/javavscode/pull/432)
31+
* Updated the JavaLangFeatures feature name extractor to work with JDK25+ EA [#451](https://github.com/oracle/javavscode/pull/451)
32+
* Constructor init of java.lsp.server JavaPlatformProvider override [#453](https://github.com/oracle/javavscode/pull/453)
33+
* Extension restart fix [#433](https://github.com/oracle/javavscode/pull/433)
34+
* Fix formatting issue when there is erroneous if tree [#429](https://github.com/oracle/javavscode/pull/429)
35+
* Fixed project clean and project compile commands in the command palette [#438](https://github.com/oracle/javavscode/pull/438)
36+
* Fixed enable preview event field value for Gradle and Standalone projects [#452](https://github.com/oracle/javavscode/pull/452)
37+
38+
#### Other Changes
39+
* Updated openjdk24 URL to 24.0.2 [#442](https://github.com/oracle/javavscode/pull/442)
40+
41+
**Full Changelog**: https://github.com/oracle/javavscode/compare/v24.1.0...v24.1.1
42+
2543
## Version 24.1.0
2644
### What's Changed
2745

vscode/src/configurations/handlers.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,10 @@ export const jdkHomeValueHandler = (): string | null => {
5555
null;
5656
}
5757

58+
export const projectJdkHomeValueHandler = (): string | null => {
59+
return getConfigurationValue(configKeys.projectJdkHome, null);
60+
}
61+
5862
export const projectSearchRootsValueHandler = (): string => {
5963
let projectSearchRoots: string = '';
6064
const isProjectFolderSearchLimited: boolean = !getConfigurationValue(configKeys.disableProjSearchLimit, false);

vscode/src/lsp/launchOptions.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
limitations under the License.
1515
*/
1616
import { builtInConfigKeys, configKeys } from "../configurations/configuration"
17-
import { isDarkColorThemeHandler, isNetbeansVerboseEnabled, jdkHomeValueHandler, lspServerVmOptionsHandler, projectSearchRootsValueHandler, userdirHandler } from "../configurations/handlers";
17+
import { isDarkColorThemeHandler, isNetbeansVerboseEnabled, jdkHomeValueHandler, projectJdkHomeValueHandler, lspServerVmOptionsHandler, projectSearchRootsValueHandler, userdirHandler } from "../configurations/handlers";
1818
import { l10n } from "../localiser";
1919
import { isString } from "../utils";
2020
import { userDefinedLaunchOptionsType } from "./types"
@@ -25,6 +25,10 @@ export const getUserConfigLaunchOptionsDefaults = (): userDefinedLaunchOptionsTy
2525
value: jdkHomeValueHandler(),
2626
optionToPass: ['--jdkhome']
2727
},
28+
[configKeys.projectJdkHome]: {
29+
value: projectJdkHomeValueHandler(),
30+
optionToPass: '-J-Dnetbeans.lsp.java.platform.override='
31+
},
2832
[configKeys.userdir]: {
2933
value: userdirHandler(),
3034
optionToPass: ['--userdir']

0 commit comments

Comments
 (0)