addressed review comments

Author: Achal1607

patches/6330.diff

@@ -144,15 +144,21 @@ index bb8a4e8183..b9662fe6cd 100644
                      connectionObject.getRunningFuture().get();
                  } catch (IOException | InterruptedException | ExecutionException ex) {
 diff --git a/java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/ConnectionSpecTest.java b/java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/ConnectionSpecTest.java
-index f538c953f6..e008bcda0d 100644
+index f538c953f6..728228c63c 100644
 --- a/java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/ConnectionSpecTest.java
 +++ b/java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/ConnectionSpecTest.java
-@@ -118,7 +118,7 @@ public class ConnectionSpecTest {
+@@ -118,10 +118,12 @@ public class ConnectionSpecTest {
              ByteArrayInputStream in = new ByteArrayInputStream(bytes);
              ByteArrayOutputStream os = new ByteArrayOutputStream();
              conn.prepare("Pipe server", in, os, new LspSession(), ConnectionSpecTest::setCopy, ConnectionSpecTest::copy);
 -            String reply = os.toString("UTF-8");
-+            String reply = os.toString("UTF-8".replaceAll("\n$", ""));
++            String reply = os.toString("UTF-8").replaceAll("\n$", "");
              String exp = "Pipe server listening at port ";
              assertTrue(reply, reply.startsWith(exp));
-             int port = Integer.parseInt(reply.substring(exp.length(), reply.indexOf('\n', exp.length())));
+-            int port = Integer.parseInt(reply.substring(exp.length(), reply.indexOf('\n', exp.length())));
++            int nextLineIdx = reply.indexOf('\n', exp.length());
++            if (nextLineIdx < 0) nextLineIdx = reply.length();
++            int port = Integer.parseInt(reply.substring(exp.length(), nextLineIdx));
+             assertTrue("port is specified: " + port, port >= 1024);
+             try (ConnectionSpec second = ConnectionSpec.parse("connect:" + port)) {
+                 second.prepare("Pipe client", in, os, new LspSession(), ConnectionSpecTest::setCopy, ConnectionSpecTest::copy);

vscode/package.nls.ja.json

@@ -50,7 +50,7 @@
     "jdk.debugger.configuration.classPaths.description": "JVMの起動のためのクラスパス。",
     "jdk.debugger.configuration.console.description": "プログラムを起動する指定されたコンソール。",
     "jdk.debugger.configuration.args.description": "実行クラスの引数",
-    "jdk.debugger.configuration.vmArgs.items.description": "Single argument to the Java VM",
+    "jdk.debugger.configuration.vmArgs.items.description": "Single argument for the Java VM",
     "jdk.debugger.configuration.vmArgs.description": "Java VMの引数",
     "jdk.debugger.configuration.cwd.description": "プログラム実行の作業ディレクトリ",
     "jdk.debugger.configuration.env.description": "プログラム実行の環境変数",

vscode/package.nls.json

@@ -50,7 +50,7 @@
     "jdk.debugger.configuration.classPaths.description": "The classpaths for launching the JVM.",
     "jdk.debugger.configuration.console.description": "The specified console to launch the program.",
     "jdk.debugger.configuration.args.description": "Arguments for the executed class",
-    "jdk.debugger.configuration.vmArgs.items.description": "Single argument to the Java VM",
+    "jdk.debugger.configuration.vmArgs.items.description": "Single argument for the Java VM",
     "jdk.debugger.configuration.vmArgs.description": "Arguments for the Java VM",
     "jdk.debugger.configuration.cwd.description": "Working directory for the program execution",
     "jdk.debugger.configuration.env.description": "Environment variables for the program execution",

vscode/package.nls.zh-cn.json

@@ -50,7 +50,7 @@
     "jdk.debugger.configuration.classPaths.description": "用于启动 JVM 的类路径。",
     "jdk.debugger.configuration.console.description": "用于启动程序的指定控制台。",
     "jdk.debugger.configuration.args.description": "所执行类的参数",
-    "jdk.debugger.configuration.vmArgs.items.description": "Single argument to the Java VM",
+    "jdk.debugger.configuration.vmArgs.items.description": "Single argument for the Java VM",
     "jdk.debugger.configuration.vmArgs.description": "Java VM 的参数",
     "jdk.debugger.configuration.cwd.description": "程序执行的工作目录",
     "jdk.debugger.configuration.env.description": "程序执行的环境变量",

vscode/src/lsp/listeners/requests/terminal.ts

@@ -1,3 +1,19 @@
+/*
+  Copyright (c) 2023-2025, Oracle and/or its affiliates.
+
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+     https://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+*/
+
 import { LineBufferingPseudoterminal } from "../../../views/pseudoTerminal";
 import { CloseOutputRequest, ResetOutputRequest, ShowOutputRequest, WriteOutputRequest } from "../../protocol";
 import { notificationOrRequestListenerType } from "../../types";

vscode/src/views/pseudoTerminal.ts

@@ -1,3 +1,19 @@
+/*
+  Copyright (c) 2023-2025, Oracle and/or its affiliates.
+
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+     https://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+*/
+
 import { Pseudoterminal, EventEmitter, Event, Terminal, window } from "vscode";
 
 export class LineBufferingPseudoterminal implements Pseudoterminal {