Skip to content

Commit c9e4988

Browse files
committed
removed unused codicons
1 parent 5e22af4 commit c9e4988

File tree

3 files changed

+7
-13
lines changed

3 files changed

+7
-13
lines changed

vscode/package-lock.json

Lines changed: 5 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vscode/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -923,7 +923,6 @@
923923
"@types/node": "^18.19.64",
924924
"@types/sinon": "^17.0.4",
925925
"@types/vscode": "^1.84.0",
926-
"@vscode/codicons": "0.0.36",
927926
"@vscode/test-electron": "^2.5.2",
928927
"chai": "^4.5.0",
929928
"esbuild": "^0.25.3",

vscode/src/webviews/nbWebviewHandler.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,10 @@ export const showHtmlPage = async (params: HtmlPageParams): Promise<void> => {
2727
const match = /<title>(.*)<\/title>/i.exec(data);
2828
const name = match && match.length > 1 ? match[1] : '';
2929
const resourceDir = Uri.joinPath(extensionContext.getGlobalStorage(), params.id);
30-
// TODO: @vscode/codeicons is a devDependency not a prod dependency. So do we ever reach this code?
31-
const distPath = Uri.joinPath(extensionContext.getExtensionStorageUri(), 'node_modules', '@vscode/codicons', 'dist');
3230
workspace.fs.createDirectory(resourceDir);
3331
let view = window.createWebviewPanel('htmlView', name, ViewColumn.Beside, {
3432
enableScripts: true,
35-
localResourceRoots: [resourceDir, distPath]
33+
localResourceRoots: [resourceDir]
3634
});
3735
webviews.set(params.id, view.webview);
3836
const resources = params.resources;
@@ -44,8 +42,7 @@ export const showHtmlPage = async (params: HtmlPageParams): Promise<void> => {
4442
data = data.replace(`href="${resourceName}"`, `href="${view.webview.asWebviewUri(resourceUri)}"`);
4543
}
4644
}
47-
const codiconsUri = view.webview.asWebviewUri(Uri.joinPath(distPath, 'codicon.css'));
48-
view.webview.html = data.replace('href="codicon.css"', `href="${codiconsUri}"`);
45+
view.webview.html = data;
4946
view.webview.onDidReceiveMessage(message => {
5047
switch (message.command) {
5148
case 'dispose':

0 commit comments

Comments
 (0)