builtin config keys added

Author: Achal1607

vscode/src/configurations/configuration.ts

@@ -28,16 +28,19 @@ export const configKeys = {
     runConfigCwd: 'runConfig.cwd',
     verbose: 'verbose',
     userdir: 'userdir',
-    vscodeTheme: 'workbench.colorTheme'
 };
 
-export const userConfigsListened = [
+export const builtInConfigKeys = {
+    vscodeTheme: 'workbench.colorTheme'
+}
+
+export const userConfigsListened: string[] = [
     appendPrefixToCommand(configKeys.jdkHome),
     appendPrefixToCommand(configKeys.userdir),
     appendPrefixToCommand(configKeys.lspVmOptions),
     appendPrefixToCommand(configKeys.disableNbJavac),
     appendPrefixToCommand(configKeys.disableProjSearchLimit),
-    configKeys.vscodeTheme,
+    builtInConfigKeys.vscodeTheme,
 ];
 
 

vscode/src/configurations/handlers.ts

@@ -14,7 +14,7 @@
   limitations under the License.
 */
 import { extensions, workspace } from "vscode";
-import { configKeys } from "./configuration";
+import { builtInConfigKeys, configKeys } from "./configuration";
 import { extConstants, NODE_WINDOWS_LABEL } from "../constants";
 import * as os from 'os';
 import { globalVars, LOGGER } from "../extension";
@@ -27,6 +27,14 @@ export const getConfigurationValue = <T>(key: string, defaultValue: T | undefine
     return defaultValue != undefined ? conf.get(key, defaultValue) : conf.get(key) as T;
 }
 
+export const getBuiltinConfigurationValue = <T>(key: string, defaultValue: T | undefined = undefined): T => {
+    const splitKey = key.split('.');
+    const selector = splitKey?.[0];
+    const conf = workspace.getConfiguration(selector);
+    const confKey = splitKey?.slice(1)?.join('.');
+    return defaultValue != undefined ? conf?.get(confKey, defaultValue) : conf?.get(confKey) as T;
+}
+
 export const jdkHomeValueHandler = (): string | null => {
     return getConfigurationValue(configKeys.jdkHome) ||
         process.env.JDK_HOME ||
@@ -71,8 +79,7 @@ export const lspServerVmOptionsHandler = (): string[] => {
 }
 
 export const isDarkColorThemeHandler = (): boolean => {
-    // const themeName = getConfigurationValue(configKeys.vscodeTheme);
-    const themeName = workspace.getConfiguration('workbench')?.get('colorTheme');
+    const themeName: string = getBuiltinConfigurationValue(builtInConfigKeys.vscodeTheme);    
     if (!themeName) {
         return false;
     }
@@ -110,12 +117,12 @@ export const userdirHandler = (): string => {
     const userdir = path.join(userdirParentDir, "userdir");
 
     try {
-        if(!fs.existsSync(userdir)){
+        if (!fs.existsSync(userdir)) {
             fs.mkdirSync(userdir, { recursive: true });
             const stats = fs.statSync(userdir);
             if (!stats.isDirectory()) {
                 throw new Error(`${userdir} is not a directory`);
-            }    
+            }
         }
 
         return userdir;
@@ -125,5 +132,5 @@ export const userdirHandler = (): string => {
 }
 
 export const isNbJavacDisabledHandler = (): boolean => {
-   return getConfigurationValue(configKeys.verbose, false);
+    return getConfigurationValue(configKeys.verbose, false);
 }

vscode/src/lsp/launchOptions.ts

@@ -13,7 +13,7 @@
   See the License for the specific language governing permissions and
   limitations under the License.
 */
-import { configKeys } from "../configurations/configuration"
+import { builtInConfigKeys, configKeys } from "../configurations/configuration"
 import { isDarkColorThemeHandler, isNbJavacDisabledHandler, jdkHomeValueHandler, lspServerVmOptionsHandler, projectSearchRootsValueHandler, userdirHandler } from "../configurations/handlers";
 import { l10n } from "../localiser";
 import { userDefinedLaunchOptionsType } from "./types"
@@ -35,7 +35,7 @@ export const getUserConfigLaunchOptionsDefaults = (): userDefinedLaunchOptionsTy
             value: isNbJavacDisabledHandler(),
             optionToPass: '-J-Dnetbeans.logger.console='
         },
-        [configKeys.vscodeTheme]: {
+        [builtInConfigKeys.vscodeTheme]: {
             value: isDarkColorThemeHandler() ? 'com.formdev.flatlaf.FlatDarkLaf' : null,
             optionToPass: ['--laf']
         },