Skip to content

Conversation

@Achal1607
Copy link
Member

Upgraded dev dependencies

  • @types/node: 13.11.0 -> 18.19.64
  • typescript: 4.6.4 -> 5.3.3
  • @types/mocha: 9.0.0 -> 10.0.9
  • mocha: 9.1.2 -> 10.8.2
  • @types/vscode: 1.76.0 -> 1.84.0
  • @vscode/codicons: 0.0.29 -> 0.0.36
  • esbuild: 0.16.17 -> 0.24.0

Upgraded VS Code engine

  • 1.76.0 -> 1.84.0

Removed unused dev dependencies

Replaced fs.rmdir() to fs.rm()

Deprecation warning of rmdir() was showing up earlier before upgrade of @types/node.

DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/vscode-webview/index.d.ts

So, replaced instances of rmdir with rm.

Updated package-lock.json

Deleted package-lock.json and created again (that's why it's version is changed from 2 to 3) so that it removes all the earlier redundant entries and generates a new file on the basis of updated package.json.

@Achal1607 Achal1607 requested a review from sid-srini November 6, 2024 12:42
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 6, 2024
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Achal1607. This seems fine overall.

I have left one query comment regarding the retention of optional dependencies of esbuild in the package-lock.json for you to review. Thanks.

@Achal1607 Achal1607 added the do not merge Don't merge PR label Nov 7, 2024
@Achal1607 Achal1607 changed the base branch from main to telemetry November 7, 2024 06:31
@Achal1607 Achal1607 removed the do not merge Don't merge PR label Nov 7, 2024
@Achal1607 Achal1607 merged commit ca6383d into oracle:telemetry Nov 7, 2024
3 checks passed
@Achal1607 Achal1607 deleted the upgrade-dependency branch November 7, 2024 06:32
This was referenced Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants