Initial structure of telemetry feature in the extension #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Achal1607
force-pushed
the
telemetry
branch
2 times, most recently
from
869f0dd to
03fa45c
Compare
sid-srini
requested changes
Dec 16, 2024
some bug fixes and added debug logger
Added flag to disable telemetry feature
Updated LspServerTelemetryManager with slight refinements
1. The workspaceInfo values, especially the javaVersion field.
2. Also reverted the sendTelemetry() methods to the state
similar to earlier definitions with synchronized blocks;
with minor refactoring improvements.
3. Added the missed changes in NbCodeClientCapabilities for the
addition of the wantsTelemetryEnabled field.
Signed-off-by: Siddharth Srinivasan <[email protected]>
Updated telemetry l10n with only english
1. Added the same english key value for telemetry setting and message in
all language bundles. This is to ensure that tests pass.
2. Removed the unused dependency "axios" pruned further dependencies of
it.
3. Updated minimum runtime JDK version to 23 instead of 22 in l10n messages.
Signed-off-by: Siddharth Srinivasan <[email protected]>
sid-srini
approved these changes
Dec 16, 2024
Member
sid-srini
left a comment
sid-srini
left a comment
There was a problem hiding this comment.
Thanks a lot @Achal1607. LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telemetry feature would help us collect extension usage information to improve our extension. Usage info would only be collected if user opts in for the same.