Skip to content

Conversation

@shivam71
Copy link
Member

Corrected spelling mistakes and converted the absolute url to relative one for the LICENSE file so that it doesn't point to the file in the main branch .

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 11, 2024
Copy link
Member

@Achal1607 Achal1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@Achal1607 Achal1607 added this to the JVSC 23.1.0 milestone Dec 11, 2024
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shivam71. Please update the other full main blob URLs, such as LICENSE.txt and SECURITY.md, to their relative forms too.

  • I suppose these would also get converted to the appropriate https URLs during vsix creation by the vsce --baseContentUrl option.
  • Ticket microsoft/vscode#21839 shows that vsce still has no support for relative links for media in the README.


### Run Configurations panel
Program arguments, VM options, evironment variables,... can be set in Run Configuration panel a part of Explorer. The panel is sufficient for all typical use-cases Java programmer faces. Only advanced, expert scenarios may require touching of `launch.json` (which still takes precedence).
Program arguments, VM options, environment variables,... can be set in Run Configuration panel a part of Explorer. The panel is sufficient for all typical use-cases Java programmer faces. Only advanced, expert scenarios may require touching of `launch.json` (which still takes precedence).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Program arguments, VM options, environment variables,... can be set in Run Configuration panel a part of Explorer. The panel is sufficient for all typical use-cases Java programmer faces. Only advanced, expert scenarios may require touching of `launch.json` (which still takes precedence).
Program arguments, VM options, environment variables, etc. can be set in the Run Configuration panel within VS Code's Activity bar Explorer view. The panel caters for most typical use-cases that programmers face for running their Java programs. Only advanced, expert scenarios may require using `launch.json` to define customised launch targets which take precedence over the Run Configuration.

![Project Explorer](vscode/images/project-explorer.png)

## Debugger and Launch Configurations
Language Server __Java+ ...__ launch configuration supports debugging and running Java applications using JDK11 or newer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change JDK11 to JDK8?

* Select this configuration, then click the ![Run](vscode/images/run.png)
* Select either from available process or enter the port to connect to JVM running with JDWP.
* __Attach to Shared Memory__ is available on Windows in addtion to above mentioned _Attach..._
* __Attach to Shared Memory__ is available on Windows in addition to above mentioned _Attach..._
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* __Attach to Shared Memory__ is available on Windows in addition to above mentioned _Attach..._
* __Attach to Shared Memory__ is available on Windows in addition to the _Attach..._ configurations above.

@sid-srini sid-srini merged commit 5e0811f into oracle:main Dec 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants