Skip to content

Updated the labels associated with disable/enable NbJavac shown in the settings and notifications. #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2024
Merged

Updated the labels associated with disable/enable NbJavac shown in the settings and notifications. #349

merged 1 commit into from
Dec 13, 2024

Conversation

@shivam71
Copy link
Member

@shivam71 shivam71 commented Dec 13, 2024 •
edited
Loading

  • With Netbeans 23 the extension requires javac from JDK23+ or fallback to nb-javac if not available.
  • Hence the labels associated with enable/disable Nbjavac need to state the minimum required JDK to be 23.
  • Labels present in l10n bundles and package.nls updated across the supported languages .

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 13, 2024
@shivam71 shivam71 changed the title Updated minimum runtime JDK from 22 to 23 in l10n messages. Updated the labels associated with disable/enable NbJavac shown in the settings and notifications. Dec 13, 2024
sid-srini
sid-srini approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shivam71. LGTM 👍

@sid-srini sid-srini merged commit 879f59a into oracle:main Dec 13, 2024
3 checks passed
@sid-srini sid-srini added this to the JVSC 23.1.0 milestone Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sid-srini sid-srini sid-srini approved these changes

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

JVSC 23.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@shivam71 @sid-srini