Skip to content

Conversation

@Achal1607
Copy link
Member

  • Currently dot(".") is provided by default as the code completion commit character alongwith Tab and Enter.
  • According to VSCode guidelines and modern IDEs behaviour we should only provide Tab and Enter for accepting code completion suggestions. So, removed the default . character for accepting code completion.
  • But, since some users might be already using . as their code completion character. Introduced a new configuration jdk.java.completion.commit.chars which accepts array of character for code completion commit.

@Achal1607 Achal1607 requested a review from sid-srini April 30, 2025 08:30
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 30, 2025
@Achal1607 Achal1607 added this to the JVSC 24.1.0 milestone Apr 30, 2025
sid-srini
sid-srini previously approved these changes Apr 30, 2025
Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Achal1607. LGTM 👍

Copy link
Member

@sid-srini sid-srini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@Achal1607 Achal1607 merged commit 8f0803d into oracle:main May 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants