Skip to content

Commit 46d9e84

Browse files
committed
tlshd: Don't set errno in tlshd_keyring_link_session()
- No caller ever examines the return value for tlshd_keyring_link_session(), thus the errno set here is always ignored. - The errno values set here are not documented. Clean up by removing set-but-unexamined variables. Signed-off-by: Chuck Lever <[email protected]>
1 parent 67ef5a5 commit 46d9e84

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/tlshd/keyring.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,14 +258,12 @@ int tlshd_keyring_link_session(const char *keyring)
258258

259259
if (!keyring) {
260260
tlshd_log_error("No keyring specified");
261-
errno = -EINVAL;
262261
return -1;
263262
}
264263

265264
serial = find_key_by_type_and_desc("keyring", keyring, 0);
266265
if (serial == -1) {
267266
tlshd_log_debug("Failed to find keyring '%s'\n", keyring);
268-
errno = -ENOKEY;
269267
return -1;
270268
}
271269

0 commit comments

Comments
 (0)