tlshd: Add tlshd_genl_put_handshake_parms() API

Manage dynamically-allocated resources in struct
tlshd_handshake_parms by adding a function to release these
resources before the handshake child process exits.

This improves the ability of tlshd to dynamically allocate and
manage memory containing variably-sized arguments such as hostnames,
arrays, and socket addresses.

The parms.peername and parms.peeraddr fields will be included in the
set of dynamically-allocated resources, so add the new "release" API
call /after/ the handshake completion notice.

Signed-off-by: Chuck Lever <[email protected]>

Author: chucklever

src/tlshd/handshake.c

@@ -183,9 +183,5 @@ void tlshd_service_socket(void)
 out:
 	tlshd_genl_done(&parms);
 	tlshd_log_completion(&parms);
-
-	if (parms.keyring)
-		keyctl_unlink(parms.keyring, KEY_SPEC_SESSION_KEYRING);
-
-	free(parms.peerids);
+	tlshd_genl_put_handshake_parms(&parms);
 }

src/tlshd/netlink.c

@@ -405,6 +405,18 @@ int tlshd_genl_get_handshake_parms(struct tlshd_handshake_parms *parms)
 	return ret;
 }
 
+/**
+ * tlshd_genl_put_handshake_parms - Release handshake resources
+ * @parms: handshake parameters to be released
+ *
+ */
+void tlshd_genl_put_handshake_parms(struct tlshd_handshake_parms *parms)
+{
+	if (parms->keyring)
+		keyctl_unlink(parms->keyring, KEY_SPEC_SESSION_KEYRING);
+	free(parms->peerids);
+}
+
 static int tlshd_genl_put_remote_peerids(struct nl_msg *msg,
 					 struct tlshd_handshake_parms *parms)
 {
@@ -423,7 +435,7 @@ static int tlshd_genl_put_remote_peerids(struct nl_msg *msg,
 }
 
 /**
- * tlshd_genl_done - Indicate anon handshake has completed successfully
+ * tlshd_genl_done - Indicate handshake has completed successfully
  * @parms: buffer filled in with parameters
  *
  */

src/tlshd/tlshd.h

@@ -116,6 +116,7 @@ void tlshd_log_nl_error(const char *msg, int err);
 /* netlink.c */
 extern void tlshd_genl_dispatch(void);
 extern int tlshd_genl_get_handshake_parms(struct tlshd_handshake_parms *parms);
+extern void tlshd_genl_put_handshake_parms(struct tlshd_handshake_parms *parms);
 extern void tlshd_genl_done(struct tlshd_handshake_parms *parms);
 
 /* server.c */