chore: remove unnecessary get_dep_analyzer overrides

Signed-off-by: behnazh-w <[email protected]>

Author: behnazh-w

scripts/release_scripts/run_macaron.sh

@@ -486,20 +486,6 @@ else
             argv_command+=("--local-maven-repo" "${MACARON_WORKSPACE}/analyze_local_maven_repo_readonly")
 
             mount_dir_ro "--local-maven-repo" "$HOME/.m2" "$local_maven_repo_in_container"
-        # If the host's $HOME/.m2 doesn't exist, we create and mount an empty directory ${output}/analyze_local_maven_repo_readonly
-        # into ${MACARON_WORKSPACE}/analyze_local_maven_repo_readonly. And then provide
-        # ${MACARON_WORKSPACE}/analyze_local_maven_repo_readonly into the --local-maven-repo
-        # flag.
-        # This is because:
-        #   - By default if --local-maven-repo is not used, Macaron uses $HOME/.m2 of the current
-        #     environment as the local maven repo.
-        else
-            local_maven_repo_in_container="${MACARON_WORKSPACE}/analyze_local_maven_repo_readonly"
-            output_local_maven_repo="${output}/analyze_local_maven_repo_readonly"
-            mkdir -p "$output_local_maven_repo"
-            argv_command+=("--local-maven-repo" "${MACARON_WORKSPACE}/analyze_local_maven_repo_readonly")
-
-            mount_dir_ro "--local-maven-repo" "$output_local_maven_repo" "$local_maven_repo_in_container"
         fi
     fi
 fi

src/macaron/slsa_analyzer/build_tool/docker.py

@@ -7,7 +7,6 @@
 """
 
 from macaron.config.defaults import defaults
-from macaron.dependency_analyzer.cyclonedx import NoneDependencyAnalyzer
 from macaron.slsa_analyzer.build_tool.base_build_tool import BaseBuildTool, file_exists
 from macaron.slsa_analyzer.build_tool.language import BuildLanguage
 
@@ -45,19 +44,3 @@ def is_detected(self, repo_path: str) -> bool:
             True if this build tool is detected, else False.
         """
         return any(file_exists(repo_path, file) for file in self.build_configs)
-
-    def get_dep_analyzer(self) -> NoneDependencyAnalyzer:
-        """Create a DependencyAnalyzer for the Docker build tool. Currently unimplemented.
-
-        Returns
-        -------
-        NoneDependencyAnalyser
-            The NoneDependencyAnalyser object.
-
-        Raises
-        ------
-        DependencyAnalyzerError
-        """
-        # TODO: Find a suitable tool to analyse dependencies; as of now Syft
-        #       seems to be a good option, but need to experiment.
-        return NoneDependencyAnalyzer()

src/macaron/slsa_analyzer/build_tool/go.py

@@ -7,7 +7,6 @@
 """
 
 from macaron.config.defaults import defaults
-from macaron.dependency_analyzer.cyclonedx import DependencyAnalyzer, NoneDependencyAnalyzer
 from macaron.slsa_analyzer.build_tool.base_build_tool import BaseBuildTool, file_exists
 from macaron.slsa_analyzer.build_tool.language import BuildLanguage
 
@@ -45,14 +44,3 @@ def is_detected(self, repo_path: str) -> bool:
         """
         go_config_files = self.build_configs + self.entry_conf
         return any(file_exists(repo_path, file) for file in go_config_files)
-
-    def get_dep_analyzer(self) -> DependencyAnalyzer:
-        """Create a DependencyAnalyzer for the build tool.
-
-        Returns
-        -------
-        DependencyAnalyzer
-            The DependencyAnalyzer object.
-        """
-        # TODO: Implement this method.
-        return NoneDependencyAnalyzer()

src/macaron/slsa_analyzer/build_tool/gradle.py

@@ -10,7 +10,6 @@
 import subprocess  # nosec B404
 
 from macaron.config.defaults import defaults
-from macaron.dependency_analyzer.cyclonedx import DependencyAnalyzer, NoneDependencyAnalyzer
 from macaron.slsa_analyzer.build_tool.base_build_tool import BaseBuildTool, file_exists
 from macaron.slsa_analyzer.build_tool.language import BuildLanguage
 
@@ -70,20 +69,6 @@ def is_detected(self, repo_path: str) -> bool:
         gradle_config_files = self.build_configs + self.entry_conf
         return any(file_exists(repo_path, file) for file in gradle_config_files)
 
-    def get_dep_analyzer(self) -> DependencyAnalyzer:
-        """Create a DependencyAnalyzer for the Gradle build tool.
-
-        Returns
-        -------
-        DependencyAnalyzer
-            The DependencyAnalyzer object.
-
-        Raises
-        ------
-        DependencyAnalyzerError
-        """
-        return NoneDependencyAnalyzer()
-
     def get_group_id(self, gradle_exec: str, project_path: str) -> str | None:
         """Get the group id of a Gradle project.
 

src/macaron/slsa_analyzer/build_tool/maven.py

@@ -11,7 +11,6 @@
 
 from macaron.config.defaults import defaults
 from macaron.config.global_config import global_config
-from macaron.dependency_analyzer.cyclonedx import DependencyAnalyzer, NoneDependencyAnalyzer
 from macaron.slsa_analyzer.build_tool.base_build_tool import BaseBuildTool, file_exists
 from macaron.slsa_analyzer.build_tool.language import BuildLanguage
 
@@ -65,18 +64,3 @@ def is_detected(self, repo_path: str) -> bool:
             return False
         maven_config_files = self.build_configs
         return any(file_exists(repo_path, file) for file in maven_config_files)
-
-    def get_dep_analyzer(self) -> DependencyAnalyzer:
-        """
-        Create a DependencyAnalyzer for the Maven build tool.
-
-        Returns
-        -------
-        DependencyAnalyzer
-            The DependencyAnalyzer object.
-
-        Raises
-        ------
-        DependencyAnalyzerError
-        """
-        return NoneDependencyAnalyzer()

src/macaron/slsa_analyzer/build_tool/npm.py

@@ -11,7 +11,6 @@
 import os
 
 from macaron.config.defaults import defaults
-from macaron.dependency_analyzer.cyclonedx import DependencyAnalyzer, NoneDependencyAnalyzer
 from macaron.slsa_analyzer.build_tool.base_build_tool import BaseBuildTool, BuildToolCommand, file_exists
 from macaron.slsa_analyzer.build_tool.language import BuildLanguage
 from macaron.slsa_analyzer.checks.check_result import Confidence
@@ -59,17 +58,6 @@ def is_detected(self, repo_path: str) -> bool:
         npm_config_files = self.build_configs + self.package_lock + self.entry_conf
         return any(file_exists(repo_path, file) for file in npm_config_files)
 
-    def get_dep_analyzer(self) -> DependencyAnalyzer:
-        """Create a DependencyAnalyzer for the build tool.
-
-        Returns
-        -------
-        DependencyAnalyzer
-            The DependencyAnalyzer object.
-        """
-        # TODO: Implement this method.
-        return NoneDependencyAnalyzer()
-
     def is_deploy_command(
         self, cmd: BuildToolCommand, excluded_configs: list[str] | None = None, provenance_workflow: str | None = None
     ) -> tuple[bool, Confidence]:

src/macaron/slsa_analyzer/build_tool/yarn.py

@@ -10,7 +10,6 @@
 import os
 
 from macaron.config.defaults import defaults
-from macaron.dependency_analyzer.cyclonedx import DependencyAnalyzer, NoneDependencyAnalyzer
 from macaron.slsa_analyzer.build_tool.base_build_tool import BaseBuildTool, BuildToolCommand, file_exists
 from macaron.slsa_analyzer.build_tool.language import BuildLanguage
 from macaron.slsa_analyzer.checks.check_result import Confidence
@@ -57,17 +56,6 @@ def is_detected(self, repo_path: str) -> bool:
         yarn_config_files = self.build_configs + self.package_lock + self.entry_conf
         return any(file_exists(repo_path, file) for file in yarn_config_files)
 
-    def get_dep_analyzer(self) -> DependencyAnalyzer:
-        """Create a DependencyAnalyzer for the build tool.
-
-        Returns
-        -------
-        DependencyAnalyzer
-            The DependencyAnalyzer object.
-        """
-        # TODO: Implement this method.
-        return NoneDependencyAnalyzer()
-
     def is_deploy_command(
         self, cmd: BuildToolCommand, excluded_configs: list[str] | None = None, provenance_workflow: str | None = None
     ) -> tuple[bool, Confidence]: