Skip to content

Commit 58602b1

Browse files
authored
fix(release): disable SLSA provenance for now (#277)
Unfortunately, we need approval for running SLSA provenance genrator's third-party GitHub Actions. We disable provenance generation until this issue is resolved: slsa-framework/slsa-github-generator#2204. Signed-off-by: behnazh-w <[email protected]>
1 parent 5be116f commit 58602b1

File tree

1 file changed

+51
-49
lines changed

1 file changed

+51
-49
lines changed

.github/workflows/release.yaml

Lines changed: 51 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -258,64 +258,66 @@ jobs:
258258
# TWINE_PASSWORD=<PASSWORD>
259259
# TWINE_REPOSITORY_URL=<REPOSITORY_URL>
260260

261+
# Uncomment the provenance generation once we have approval for running its third-party
262+
# GitHub Actions. See https://github.com/slsa-framework/slsa-github-generator/issues/2204.
261263
# Generate the build provenance. The generator should be referenced with a semantic version.
262264
# The build will fail if we reference it using the commit SHA. To avoid using a pre-built
263265
# provenance generator which depends on an external service Rekor (https://github.com/sigstore/rekor)
264266
# we build this generator from source for now. For more information see this discussion:
265267
# https://github.com/slsa-framework/slsa-github-generator/issues/942
266-
provenance:
267-
needs: [build, release]
268-
uses: slsa-framework/slsa-github-generator/.github/workflows/[email protected]
269-
with:
270-
base64-subjects: ${{ needs.build.outputs.artifacts-sha256 }}
271-
compile-generator: true # Build the generator from source.
272-
# Set private-repository to true for private repositories. Note that the repository name is
273-
# uploaded as part of the transparency log entry on the public Rekor instance (rekor.sigstore.dev).
274-
private-repository: false
275-
provenance-name: macaron-${{ needs.release.outputs.release-version }}.intoto.jsonl
276-
permissions:
277-
actions: read # To read the workflow path.
278-
id-token: write # To sign the provenance.
279-
contents: write # To add assets to a release.
268+
# provenance:
269+
# needs: [build, release]
270+
# uses: slsa-framework/slsa-github-generator/.github/workflows/[email protected]
271+
# with:
272+
# base64-subjects: ${{ needs.build.outputs.artifacts-sha256 }}
273+
# compile-generator: true # Build the generator from source.
274+
# # Set private-repository to true for private repositories. Note that the repository name is
275+
# # uploaded as part of the transparency log entry on the public Rekor instance (rekor.sigstore.dev).
276+
# private-repository: false
277+
# provenance-name: macaron-${{ needs.release.outputs.release-version }}.intoto.jsonl
278+
# permissions:
279+
# actions: read # To read the workflow path.
280+
# id-token: write # To sign the provenance.
281+
# contents: write # To add assets to a release.
280282

281283
# Generate SLSA provenance for the Docker image and push it to the container registry.
282-
provenance-docker:
283-
needs: [release]
284-
permissions:
285-
actions: read # To detect the Github Actions environment.
286-
id-token: write # To create OIDC tokens for signing.
287-
packages: write # To upload provenance.
288-
uses: slsa-framework/slsa-github-generator/.github/workflows/[email protected]
289-
with:
290-
image: ${{ needs.release.outputs.image-name }}
291-
digest: ${{ needs.release.outputs.image-digest }}
292-
registry-username: ${{ github.actor }}
293-
secrets:
294-
registry-password: ${{ secrets.GITHUB_TOKEN }}
284+
# provenance-docker:
285+
# needs: [release]
286+
# permissions:
287+
# actions: read # To detect the Github Actions environment.
288+
# id-token: write # To create OIDC tokens for signing.
289+
# packages: write # To upload provenance.
290+
# uses: slsa-framework/slsa-github-generator/.github/workflows/[email protected]
291+
# with:
292+
# image: ${{ needs.release.outputs.image-name }}
293+
# digest: ${{ needs.release.outputs.image-digest }}
294+
# registry-username: ${{ github.actor }}
295+
# secrets:
296+
# registry-password: ${{ secrets.GITHUB_TOKEN }}
295297

296298
# Publish the SLSA provenance as the GitHub release asset.
297-
publish_provenance:
298-
needs: [release, provenance]
299-
name: Publish provenance
300-
runs-on: ubuntu-latest
301-
permissions:
302-
contents: write # To publish release notes.
303-
steps:
304-
305-
- name: Check out repository
306-
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2
307-
with:
308-
fetch-depth: 0
309-
310-
- name: Download provenance
311-
uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
312-
with:
313-
name: ${{ needs.provenance.outputs.provenance-name }}
314-
315-
- name: Upload provenance
316-
run: gh release upload ${{ needs.release.outputs.release-tag }} ${{ needs.provenance.outputs.provenance-name }}
317-
env:
318-
GH_TOKEN: ${{ secrets.REPO_ACCESS_TOKEN }}
299+
# publish_provenance:
300+
# needs: [release, provenance]
301+
# name: Publish provenance
302+
# runs-on: ubuntu-latest
303+
# permissions:
304+
# contents: write # To publish release notes.
305+
# steps:
306+
307+
# - name: Check out repository
308+
# uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2
309+
# with:
310+
# fetch-depth: 0
311+
312+
# - name: Download provenance
313+
# uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
314+
# with:
315+
# name: ${{ needs.provenance.outputs.provenance-name }}
316+
317+
# - name: Upload provenance
318+
# run: gh release upload ${{ needs.release.outputs.release-tag }} ${{ needs.provenance.outputs.provenance-name }}
319+
# env:
320+
# GH_TOKEN: ${{ secrets.REPO_ACCESS_TOKEN }}
319321

320322
# Publish docs to GitHub pages.
321323
github-pages:

0 commit comments

Comments
 (0)