chore: address PR feedback

Signed-off-by: behnazh-w <[email protected]>

Author: behnazh-w

tests/build_spec_generator/cli_command_parser/test_gradle_cli_command.py

@@ -4,8 +4,6 @@
 """This module contains tests for the gradle_cli_command module."""
 
 
-from typing import Any
-
 import pytest
 
 from macaron.build_spec_generator.cli_command_parser.gradle_cli_command import GradleCLIOptions
@@ -80,33 +78,6 @@ def test_comparing_gradle_cli_command_unequal(
     assert not this_command == that_command
 
 
-@pytest.mark.parametrize(
-    ("command", "that"),
-    [
-        (
-            "gradle clean build -x test --debug --stacktrace -Dorg.gradle.caching=true",
-            True,
-        ),
-        (
-            "gradle clean build -x test --debug --stacktrace -Dorg.gradle.caching=true",
-            ["boo", "foo"],
-        ),
-        (
-            "gradle clean build -x test --debug --stacktrace -Dorg.gradle.caching=true",
-            {"boo", "foo"},
-        ),
-    ],
-)
-def test_comparing_gradle_cli_command_unequal_types(
-    gradle_cli_parser: GradleCLICommandParser,
-    command: str,
-    that: Any,
-) -> None:
-    """Test comparing MavenCLICommand with another incompatible type oject."""
-    this_command = gradle_cli_parser.parse(command.split())
-    assert not this_command == that
-
-
 @pytest.mark.parametrize(
     ("command"),
     [

tests/build_spec_generator/cli_command_parser/test_maven_cli_command.py

@@ -3,8 +3,6 @@
 
 """This module contains tests for the maven_cli_command module."""
 
-from typing import Any
-
 import pytest
 
 from macaron.build_spec_generator.cli_command_parser.maven_cli_command import MavenCLIOptions
@@ -65,33 +63,6 @@ def test_comparing_maven_cli_command_unequal(
     assert not this_command == that_command
 
 
-@pytest.mark.parametrize(
-    ("command", "that"),
-    [
-        (
-            "mvn clean package -P profile1,profile2 -T 2C -ntp -Dmaven.skip.test=true -Dboo=foo",
-            True,
-        ),
-        (
-            "mvn clean package -P profile1,profile2 -T 2C -ntp -Dmaven.skip.test=true -Dboo=foo",
-            ["boo", "foo"],
-        ),
-        (
-            "mvn clean package -P profile1,profile2 -T 2C -ntp -Dmaven.skip.test=true -Dboo=foo",
-            {"boo", "foo"},
-        ),
-    ],
-)
-def test_comparing_maven_cli_command_unequal_types(
-    maven_cli_parser: MavenCLICommandParser,
-    command: str,
-    that: Any,
-) -> None:
-    """Test comparing MavenCLICommand with another incompatible type oject."""
-    this_command = maven_cli_parser.parse(command.split())
-    assert not this_command == that
-
-
 @pytest.mark.parametrize(
     ("command"),
     [

tests/build_spec_generator/reproducible_central/compare_rc_build_spec.py

@@ -62,7 +62,7 @@ def compare_rc_build_spec(
         The result object.
     expected : dict[str, str]
         The expected object.
-    compare_fn_map : str
+    compare_fn_map : dict[str, CompareFn]
         A map from field name to corresponding compare function.
 
     Returns

tests/build_spec_generator/test_build_command_patcher.py

@@ -470,7 +470,7 @@ def test_patching_multiple_commands(
                 break
 
         if effective_cli_parser:
-            expected_cli_commands.append(cli_parser.parse(cmd))
+            expected_cli_commands.append(effective_cli_parser.parse(cmd))
         else:
             expected_cli_commands.append(
                 UnparsedCLICommand(

tests/build_spec_generator/test_macaron_db_extractor.py

@@ -282,7 +282,7 @@ def test_lookup_any_build_command_empty_db(macaron_db_session: Session) -> None:
     assert not lookup_any_build_command(component_id=1, session=macaron_db_session)
 
 
-def test_invalid_input_databse(invalid_db_session: Session) -> None:
+def test_invalid_input_database(invalid_db_session: Session) -> None:
     """Test handling invalid input database."""
     with pytest.raises(QueryMacaronDatabaseError):
         lookup_any_build_command(

tests/vsa/compare_vsa.py

@@ -126,7 +126,7 @@ def compare_list(
         The result array.
     expected : list
         The expected array.
-    compare_fn_map : str
+    compare_fn_map : dict[str, CompareFn]
         A map from field name to corresponding compare function.
     name : str
         The name of the field whose value is being compared in this function.
@@ -169,7 +169,7 @@ def compare_dict(
         The result object.
     expected : dict
         The expected object.
-    compare_fn_map : str
+    compare_fn_map : dict[str, CompareFn]
         A map from field name to corresponding compare function.
     name : str
         The name of the field whose value is being compared in this function.