fix: fix the sql statement for obtaining build check facts where the check result was mistakenly joined on the checkfacts.id instead og checkfact.check_result_id

Trong Nhan Mai · Trong Nhan Mai · commit b4ffe6b52ae8 · 2025-08-19T09:51:35.000+10:00
diff --git a/src/macaron/build_spec_generator/macaron_db_extractor.py b/src/macaron/build_spec_generator/macaron_db_extractor.py
@@ -240,7 +240,7 @@ def get_sql_stmt_build_as_code_check(component_id: int) -> Select[tuple[BuildAsC
         )
         .join(
             CheckFacts,
-            onclause=MappedCheckResult.id == CheckFacts.id,
+            onclause=MappedCheckResult.id == CheckFacts.check_result_id,
         )
         .join(
             build_as_code_facts_alias,
@@ -287,7 +287,7 @@ def get_sql_stmt_build_service_check(component_id: int) -> Select[tuple[BuildSer
         )
         .join(
             CheckFacts,
-            onclause=MappedCheckResult.id == CheckFacts.id,
+            onclause=MappedCheckResult.id == CheckFacts.check_result_id,
         )
         .join(
             build_service_facts_alias,
@@ -330,11 +330,11 @@ def get_sql_stmt_build_script_check(component_id: int) -> Select[tuple[BuildScri
         .select_from(Component)
         .join(
             MappedCheckResult,
-            onclause=Component.id == MappedCheckResult.component_id,
+            onclause=MappedCheckResult.component_id == Component.id,
         )
         .join(
             CheckFacts,
-            onclause=MappedCheckResult.id == CheckFacts.id,
+            onclause=MappedCheckResult.id == CheckFacts.check_result_id,
         )
         .join(
             build_script_facts_alias,

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ def get_sql_stmt_build_as_code_check(component_id: int) -> Select[tuple[BuildAsC`
`240`	`240`	`)`
`241`	`241`	`.join(`
`242`	`242`	`CheckFacts,`
`243`		`- onclause=MappedCheckResult.id == CheckFacts.id,`
	`243`	`+ onclause=MappedCheckResult.id == CheckFacts.check_result_id,`
`244`	`244`	`)`
`245`	`245`	`.join(`
`246`	`246`	`build_as_code_facts_alias,`
`@@ -287,7 +287,7 @@ def get_sql_stmt_build_service_check(component_id: int) -> Select[tuple[BuildSer`
`287`	`287`	`)`
`288`	`288`	`.join(`
`289`	`289`	`CheckFacts,`
`290`		`- onclause=MappedCheckResult.id == CheckFacts.id,`
	`290`	`+ onclause=MappedCheckResult.id == CheckFacts.check_result_id,`
`291`	`291`	`)`
`292`	`292`	`.join(`
`293`	`293`	`build_service_facts_alias,`
`@@ -330,11 +330,11 @@ def get_sql_stmt_build_script_check(component_id: int) -> Select[tuple[BuildScri`
`330`	`330`	`.select_from(Component)`
`331`	`331`	`.join(`
`332`	`332`	`MappedCheckResult,`
`333`		`- onclause=Component.id == MappedCheckResult.component_id,`
	`333`	`+ onclause=MappedCheckResult.component_id == Component.id,`
`334`	`334`	`)`
`335`	`335`	`.join(`
`336`	`336`	`CheckFacts,`
`337`		`- onclause=MappedCheckResult.id == CheckFacts.id,`
	`337`	`+ onclause=MappedCheckResult.id == CheckFacts.check_result_id,`
`338`	`338`	`)`
`339`	`339`	`.join(`
`340`	`340`	`build_script_facts_alias,`