test: refactor build spec unit tests and add tests for some small function in reproducible_central.py

Author: Trong Nhan Mai

src/macaron/build_spec_generator/cli_command_parser/maven_cli_parser.py

@@ -580,7 +580,7 @@ def apply_option_patch(
                 setattr(new_maven_cli_options, attr_name, patch_value)
                 continue
 
-            # Only for "-D/--define" we patch it differently than other options.
+            # Only for "-D/--define" we patch it differently.
             if option_long_name == "--define":
                 new_maven_cli_options.define = self._patch_properties_mapping(
                     original_props=new_maven_cli_options.define or {},

src/macaron/build_spec_generator/reproducible_central/reproducible_central.py

@@ -114,14 +114,8 @@ def _get_build_command_sequence(cmds_sequence: list[list[str]]) -> str:
     The build commands in the sequence will be && together, because RC's build spec
     is a shell script.
     """
-    result = ""
-    if not cmds_sequence:
-        return result
-
-    result += " ".join(remove_shell_quote(cmds_sequence[0]))
-    for cmd in cmds_sequence[1:]:
-        result += f"&& {' '.join(remove_shell_quote(cmd))}"
-
+    removed_shell_quote = [" ".join(remove_shell_quote(cmds)) for cmds in cmds_sequence]
+    result = " && ".join(removed_shell_quote)
     return result
 
 
@@ -203,14 +197,14 @@ def _gen_reproducible_central_build_spec(
     logger.debug(
         "Generating build spec for %s with command patches:\n%s",
         purl,
-        pformat(patches, indent=1),
+        pformat(patches),
     )
 
     group = purl.namespace
     artifact = purl.name
     version = purl.version
     if group is None or version is None:
-        logger.error("Missing group and/or version for Maven purl %s.", purl.to_string())
+        logger.error("Missing group and/or version for purl %s.", purl.to_string())
         return None
 
     extra_comments.append(f"Input PURL - {purl}")

tests/build_spec_generator/test_base_cli_options.py renamed to tests/build_spec_generator/cli_command_parser/test_base_cli_options.py

@@ -0,0 +1,64 @@
+# Copyright (c) 2025 - 2025, Oracle and/or its affiliates. All rights reserved.
+# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/.
+
+"""This module contains the tests for Reproducible Central build spec generation"""
+
+import pytest
+
+from macaron.build_spec_generator.reproducible_central.reproducible_central import (
+    _get_build_command_sequence,
+    _get_extra_comments,
+)
+
+
+@pytest.mark.parametrize(
+    ("comments", "expected"),
+    [
+        pytest.param(
+            [
+                "Input PURL - pkg:maven/oracle/[email protected]",
+                "Initial default JDK version 8 and default build command boo",
+            ],
+            "# Input PURL - pkg:maven/oracle/[email protected]\n# Initial default JDK version 8 and default build command boo",
+        ),
+        pytest.param(
+            [
+                "Input PURL - pkg:maven/oracle/[email protected]",
+            ],
+            "# Input PURL - pkg:maven/oracle/[email protected]",
+        ),
+        pytest.param(
+            [],
+            "",
+        ),
+    ],
+)
+def test_get_extra_comments(comments: list[str], expected: str) -> None:
+    """Test the _get_extra_comments function."""
+    assert _get_extra_comments(comments) == expected
+
+
+@pytest.mark.parametrize(
+    ("cmds_sequence", "expected"),
+    [
+        pytest.param(
+            [
+                "make clean".split(),
+                "mvn clean package".split(),
+            ],
+            "make clean && mvn clean package",
+        ),
+        pytest.param(
+            [
+                "mvn clean package".split(),
+            ],
+            "mvn clean package",
+        ),
+    ],
+)
+def test_get_build_command_sequence(
+    cmds_sequence: list[list[str]],
+    expected: str,
+) -> None:
+    """Test the _get_build_command_sequence function."""
+    assert _get_build_command_sequence(cmds_sequence) == expected