Allow an empty object for fetchInfo

Author: cjbj

src/njsConnection.cpp

@@ -1074,15 +1074,12 @@ bool njsConnection::ProcessOptions(Nan::NAN_METHOD_ARGS_TYPE args,
     if (!val->IsUndefined() && !val->IsNull()) {
         Local<Object> jsFetchInfo = val->ToObject();
         Local<Array> keys = jsFetchInfo->GetOwnPropertyNames();
-        if (keys->Length() == 0) {
-            baton->error = njsMessages::Get(errEmptyArrayForFetchAs, index);
-            return false;
-        }
         baton->numFetchInfo = keys->Length();
-        baton->fetchInfo = new njsFetchInfo[baton->numFetchInfo];
+        if (baton->numFetchInfo > 0)
+            baton->fetchInfo = new njsFetchInfo[baton->numFetchInfo];
         for (uint32_t i = 0; i < baton->numFetchInfo; i++) {
-          Local<String> temp = Nan::Get (keys,
-                                         i).ToLocalChecked ().As<String>();
+            Local<String> temp =
+                    Nan::Get(keys, i).ToLocalChecked().As<String>();
 
             v8::String::Utf8Value utf8str(temp->ToString());
             baton->fetchInfo[i].name = std::string(*utf8str,

src/njsMessages.cpp

@@ -55,7 +55,6 @@ static const char *errMsg[] = {
     "NJS-017: concurrent operations on ResultSet are not allowed", // errBusyResultSet
     "NJS-018: invalid ResultSet",                   // errInvalidResultSet
     "NJS-019: ResultSet cannot be returned for non-query statements", // errInvalidNonQueryExecution
-    "NJS-020: empty array was specified to fetch values as string", // errEmptyArrayForFetchAs
     "NJS-021: invalid type for conversion specified", // errInvalidTypeForConversion
     "NJS-022: invalid Lob",                           // errInvalidLob
     "NJS-023: concurrent operations on LOB are not allowed",  // errBusyLob

src/njsMessages.h

@@ -58,7 +58,6 @@ typedef enum {
     errBusyResultSet,
     errInvalidResultSet,
     errInvalidNonQueryExecution,
-    errEmptyArrayForFetchAs,
     errInvalidTypeForConversion,
     errInvalidLob,
     errBusyLob,

test/fetchAs.js

@@ -372,15 +372,12 @@ describe('56. fetchAs.js', function() {
       "select sysdate as ts_date from dual",
       { },
       {
-        fetchInfo: { }
+        fetchInfo: {}
       },
       function(err, result) {
-        should.exist(err);
-        should.strictEqual(
-          err.message,
-          'NJS-020: empty array was specified to fetch values as string'
-        );
-        should.not.exist(result);
+        should.not.exist(err);
+        should.exist(result);
+        (result.rows[0][0]).should.be.a.Date();
         done();
       }
     );