Fixed bug when a break occurs in the middle of processing a lengthy database response

Author: sharadraju

doc/src/release_notes.rst

@@ -13,6 +13,10 @@ Thin Mode Changes
 
 #)  Fixed bug to handle errors while waiting for writes to drain on the network.
 
+#)  Fixed bug when a break occurs in the middle of processing a database
+    response that spans multiple packets. This break could occur due to a
+    server error, the session being killed or a call to `breakExecution()`.
+
 node-oracledb `v6.0.2 <https://github.com/oracle/node-oracledb/compare/v6.0.1...v6.0.2>`__ (27 Jun 2023)
 --------------------------------------------------------------------------------------------------------
 
@@ -47,8 +51,8 @@ Thin Mode Changes
     credentials.
 
 #)  Added support for connecting with multiple network aliases for a single
-    connect string entry in the tnsnames.ora file. 
-    for example, alias1, alias2, alias3=(description=...)
+    connect string entry in the tnsnames.ora file.
+    For example, alias1, alias2, alias3=(description=...).
 
 #)  Minor internal code cleanup.
 

lib/thin/protocol/packet.js

@@ -256,7 +256,7 @@ class ReadPacket extends BaseBuffer {
   receivePacket() {
     if (this.savedBufferPos === this.savedBuffers.length) {
       const packet = this.nsi.syncRecvPacket();
-      if (!packet)
+      if (!packet || this.nsi.isBreak)
         throw new utils.OutOfPacketsError();
       this.savedBuffers.push(packet.buf);
     }

lib/thin/protocol/protocol.js

@@ -71,15 +71,18 @@ class Protocol {
     while (true) {     // eslint-disable-line
       if (this.nsi.isBreak) {
         await this.resetMessage();
+        delete this.readBuf.savedBuffers;
         await this.readBuf.waitForPackets();
       }
       try {
         message.decode(this.readBuf);
         break;
       } catch (err) {
         if (err instanceof utils.OutOfPacketsError) {
-          await this.readBuf.waitForPackets();
-          this.readBuf.restorePoint();
+          if (!this.nsi.isBreak) {
+            await this.readBuf.waitForPackets();
+            this.readBuf.restorePoint();
+          }
           continue;
         }
         throw (err);