Optimization with PL/SQL usage in executeMany with Implicit Connection Pooling

Author: sharadraju

lib/errors.js

@@ -144,7 +144,6 @@ const ERR_VECTOR_FORMAT_NOT_SUPPORTED = 144;
 const ERR_VECTOR_VERSION_NOT_SUPPORTED = 145;
 const ERR_OBJECT_IS_NOT_A_COLLECTION = 146;
 const ERR_CURSOR_HAS_BEEN_CLOSED = 147;
-const ERR_INVALID_POOL_BOUNDARY = 148;
 
 // Oracle Net layer errors start from 500
 const ERR_CONNECTION_CLOSED = 500;
@@ -190,7 +189,6 @@ adjustErrorXref.set("ORA-00600", ERR_CONNECTION_CLOSED);
 adjustErrorXref.set("ORA-24338", ERR_INVALID_REF_CURSOR);
 adjustErrorXref.set("ORA-25708", ERR_TOKEN_HAS_EXPIRED);
 adjustErrorXref.set("ORA-24344", WRN_COMPILATION_CREATE);
-adjustErrorXref.set("ORA-24510", ERR_INVALID_POOL_BOUNDARY);
 
 // define mapping for error messages
 const messages = new Map();
@@ -422,8 +420,6 @@ messages.set(ERR_OBJECT_IS_NOT_A_COLLECTION,            // NJS-146
   'object %s is not a collection');
 messages.set(ERR_CURSOR_HAS_BEEN_CLOSED,                // NJS-147
   'cursor has been closed by the database');
-messages.set(ERR_INVALID_POOL_BOUNDARY,                 // NJS-148
-  'invalid value of POOL_BOUNDARY in connect string');
 
 // Oracle Net layer errors
 
@@ -816,7 +812,6 @@ module.exports = {
   ERR_VECTOR_VERSION_NOT_SUPPORTED,
   ERR_OBJECT_IS_NOT_A_COLLECTION,
   ERR_CURSOR_HAS_BEEN_CLOSED,
-  ERR_INVALID_POOL_BOUNDARY,
   ERR_CONNECTION_CLOSED_CODE: `${ERR_PREFIX}-${ERR_CONNECTION_CLOSED}`,
   WRN_COMPILATION_CREATE,
   assert,

lib/thin/connection.js

@@ -187,22 +187,18 @@ class ThinConnectionImpl extends ConnectionImpl {
     // if a PL/SQL statement requires a full execute, perform only a single
     // iteration in order to allow the determination of input/output binds
     // to be completed; after that, an execution of the remaining iterations
-    // can be performed (but only if the cursor remains intact)
-    const countIters = numIters;
-    if (statement.isPlSql && statement.requiresFullExecute) {
+    // can be performed.
+    if (statement.isPlSql && (statement.cursorId === 0 ||
+      statement.requiresFullExecute)) {
       message.numExecs = 1;
-      while (numIters > 0) {
-        numIters -= 1;
-        await this._protocol._processMessage(message);
-        statement.requiresFullExecute = false;
-        message.offset += 1;
-        if (statement.cursorId != 0) {
-          break;
-        }
-      }
+      message.noImplicitRelease = true;
+      await this._protocol._processMessage(message);
+      statement.requiresFullExecute = false;
+      message.numExecs = numIters - 1;
+      message.offset = 1;
+      message.noImplicitRelease = false;
     }
-    if (numIters > 0) {
-      message.numExecs = numIters;
+    if (message.numExecs > 0) {
       await this._protocol._processMessage(message);
       statement.requiresFullExecute = false;
     }
@@ -224,7 +220,7 @@ class ThinConnectionImpl extends ConnectionImpl {
       result.resultSet = message.resultSet;
     } else {
       statement.bufferRowIndex = 0;
-      const outBinds = thinUtil.getOutBinds(statement, countIters,
+      const outBinds = thinUtil.getOutBinds(statement, numIters,
         executeManyFlag);
       if (outBinds) {
         result.outBinds = outBinds;

lib/thin/protocol/constants.js

@@ -464,6 +464,7 @@ module.exports = {
   TNS_EXEC_OPTION_DESCRIBE: 0x20000,
   TNS_EXEC_OPTION_NO_COMPRESSED_FETCH: 0x40000,
   TNS_EXEC_OPTION_BATCH_ERRORS: 0x80000,
+  TNS_EXEC_OPTION_NO_IMPL_REL: 0x200000,
 
   // server side piggyback op codes
   TNS_SERVER_PIGGYBACK_QUERY_CACHE_INVALIDATION: 1,

lib/thin/protocol/messages/execute.js

@@ -68,13 +68,17 @@ class ExecuteMessage extends MessageWithData {
     const stmt = this.statement;
     const params = stmt.bindInfoList;
 
+    if (this.noImplicitRelease) {
+      dmlOptions |= constants.TNS_EXEC_OPTION_NO_IMPL_REL;
+    }
+
     if (!stmt.requiresDefine && !this.parseOnly && params) {
       numParams = params.length;
     }
     if (stmt.requiresDefine) {
       options |= constants.TNS_EXEC_OPTION_DEFINE;
     } else if (!this.parseOnly && stmt.sql) {
-      dmlOptions = constants.TNS_EXEC_OPTION_IMPLICIT_RESULTSET;
+      dmlOptions |= constants.TNS_EXEC_OPTION_IMPLICIT_RESULTSET;
       options |= constants.TNS_EXEC_OPTION_EXECUTE;
     }
     if (stmt.cursorId === 0 || stmt.isDdl) {

test/executeMany1.js

@@ -492,6 +492,38 @@ describe('163. executeMany1.js', function() {
     await dotruncate();
   }); // 163.16
 
+  it('163.17 calls PL/SQL, with round trip count check', async function() {
+    if (!dbConfig.test.DBA_PRIVILEGE) {
+      this.skip();
+    }
+    await doCreateProc();
+    const plsql = "BEGIN nodb_proc_em(:1, :2, :3); END;";
+    const binds = [ [1], [2], [3], [4], [6]];
+    const options = {
+      bindDefs: [
+        { type: oracledb.NUMBER },
+        { type: oracledb.NUMBER, dir: oracledb.BIND_OUT },
+        { type: oracledb.STRING, dir: oracledb.BIND_OUT, maxSize: 20 }
+      ]
+    };
+    const sid = await testsUtil.getSid(conn);
+    const rt1 = await testsUtil.getRoundTripCount(sid);
+    await conn.executeMany(plsql, binds, options);
+    const rt2 = await testsUtil.getRoundTripCount(sid);
+    let result = false;
+    // thick does OAL8 after each iterations. Round trip count increases
+    // with each iteration.
+    if (dbConfig.test.mode === 'thick' && rt2 - rt1 === 5) {
+      result = true;
+    }
+
+    if (dbConfig.test.mode === 'thin' && rt2 - rt1 < 3) {
+      result = true;
+    }
+    assert.deepStrictEqual(result, true);
+    await doDropProc();
+  }); // 163.17
+
   const doCreateProc = async function() {
     const proc = "CREATE OR REPLACE PROCEDURE nodb_proc_em (a_num IN NUMBER, " +
                "    a_outnum OUT NUMBER, a_outstr OUT VARCHAR2) \n" +