Skip to content

Commit 05c8c60

Browse files
cjbjcjbj
committed
Enable some UROWID tests
1 parent f2dff16 commit 05c8c60

6 files changed

+154
-36
lines changed

‎test/list.txt

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3249,7 +3249,7 @@ Overview of node-oracledb functional tests
32493249
118.1.4 works with NaN
32503250
118.1.5 works with extended ROWID
32513251
118.1.6 works with restricted ROWID
3252-
- 118.1.7 works with string 0
3252+
118.1.7 works with string 0
32533253
118.1.8 works with number 0
32543254
118.1.9 works with default bind type/dir - extended ROWID
32553255
118.1.10 works with default bind type/dir - null value
@@ -3276,7 +3276,7 @@ Overview of node-oracledb functional tests
32763276
118.3.1 update null with UROWID
32773277
118.3.2 update empty string with UROWID
32783278
118.3.3 update undefined with UROWID
3279-
- 118.3.4 works with default bind type/dir
3279+
118.3.4 works with default bind type/dir
32803280
118.3.5 works with default bind type/dir - null value
32813281
118.3.6 works with default bind type/dir - empty string
32823282
118.3.7 works with default bind type/dir - undefined
@@ -3289,7 +3289,7 @@ Overview of node-oracledb functional tests
32893289
119.1.4 works with NaN
32903290
119.1.5 works with extended ROWID
32913291
119.1.6 works with restricted ROWID
3292-
- 119.1.7 works with string 0
3292+
119.1.7 works with string 0
32933293
119.1.8 works with number 0
32943294
119.1.9 works with default bind type/dir - extended ROWID
32953295
119.1.10 works with default bind type/dir - null value
@@ -3304,7 +3304,7 @@ Overview of node-oracledb functional tests
33043304
119.2.4 works with NaN
33053305
119.2.5 works with extended ROWID
33063306
119.2.6 works with restricted ROWID
3307-
- 119.2.7 works with string 0
3307+
119.2.7 works with string 0
33083308
119.2.8 works with number 0
33093309
119.2.9 works with default bind type/dir - extended ROWID
33103310
119.2.10 works with default bind type/dir - null value
@@ -3316,7 +3316,7 @@ Overview of node-oracledb functional tests
33163316
119.3.1 update null with UROWID
33173317
119.3.2 update empty string with UROWID
33183318
119.3.3 update undefined with UROWID
3319-
- 119.3.4 works with default bind type/dir
3319+
119.3.4 works with default bind type/dir
33203320
119.3.5 works with default bind type/dir - null value
33213321
119.3.6 works with default bind type/dir - empty string
33223322
119.3.7 works with default bind type/dir - undefined
@@ -3329,7 +3329,7 @@ Overview of node-oracledb functional tests
33293329
120.1.4 works with NaN
33303330
120.1.5 works with extended ROWID
33313331
120.1.6 works with restricted ROWID
3332-
- 120.1.7 works with string 0
3332+
120.1.7 works with string 0
33333333
120.1.8 works with number 0
33343334
120.1.9 works with default bind type/dir - extended ROWID
33353335
120.1.10 works with default bind type/dir - null value
@@ -3356,7 +3356,7 @@ Overview of node-oracledb functional tests
33563356
120.3.1 update null with UROWID
33573357
120.3.2 update empty string with UROWID
33583358
120.3.3 update undefined with UROWID
3359-
- 120.3.4 works with default bind type/dir
3359+
120.3.4 works with default bind type/dir
33603360
120.3.5 works with default bind type/dir - null value
33613361
120.3.6 works with default bind type/dir - empty string
33623362
120.3.7 works with default bind type/dir - undefined
@@ -3369,7 +3369,7 @@ Overview of node-oracledb functional tests
33693369
121.1.4 works with NaN
33703370
121.1.5 works with extended ROWID
33713371
121.1.6 works with restricted ROWID
3372-
- 121.1.7 works with string 0
3372+
121.1.7 works with string 0
33733373
121.1.8 works with number 0
33743374
121.1.9 works with default bind type/dir - extended ROWID
33753375
121.1.10 works with default bind type/dir - null value
@@ -3384,7 +3384,7 @@ Overview of node-oracledb functional tests
33843384
121.2.4 works with NaN
33853385
121.2.5 works with extended ROWID
33863386
121.2.6 works with restricted ROWID
3387-
- 121.2.7 works with string 0
3387+
121.2.7 works with string 0
33883388
121.2.8 works with number 0
33893389
121.2.9 works with default bind type/dir - extended ROWID
33903390
121.2.10 works with default bind type/dir - null value
@@ -3396,7 +3396,7 @@ Overview of node-oracledb functional tests
33963396
121.3.1 update null with UROWID
33973397
121.3.2 update empty string with UROWID
33983398
121.3.3 update undefined with UROWID
3399-
- 121.3.4 works with default bind type/dir
3399+
121.3.4 works with default bind type/dir
34003400
121.3.5 works with default bind type/dir - null value
34013401
121.3.6 works with default bind type/dir - empty string
34023402
121.3.7 works with default bind type/dir - undefined
@@ -3409,7 +3409,7 @@ Overview of node-oracledb functional tests
34093409
122.1.4 works with NaN
34103410
122.1.5 works with extended ROWID
34113411
122.1.6 works with restricted ROWID
3412-
- 122.1.7 works with string 0
3412+
122.1.7 works with string 0
34133413
122.1.8 works with number 0
34143414
122.1.9 works with default bind type/dir - extended ROWID
34153415
122.1.10 works with default bind type/dir - null value
@@ -3436,7 +3436,7 @@ Overview of node-oracledb functional tests
34363436
122.3.1 update null with UROWID
34373437
122.3.2 update empty string with UROWID
34383438
122.3.3 update undefined with UROWID
3439-
- 122.3.4 works with default bind type/dir
3439+
122.3.4 works with default bind type/dir
34403440
122.3.5 works with default bind type/dir - null value
34413441
122.3.6 works with default bind type/dir - empty string
34423442
122.3.7 works with default bind type/dir - undefined

‎test/urowidFunctionBindAsString1.js

Lines changed: 37 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -149,9 +149,18 @@ describe('121. urowidFunctionBindAsString1.js', function() {
149149
funBindOut(fun_execute, content, content, done);
150150
});
151151

152-
it.skip('121.1.7 works with string 0', function(done) {
152+
it('121.1.7 works with string 0', function(done) {
153153
var content = "0";
154-
funBindOut(fun_execute, content, "00000000.0000.0000", done);
154+
var bindVar = {
155+
i: { val: insertID, type: oracledb.NUMBER, dir: oracledb.BIND_IN },
156+
c: { val: content, type: oracledb.STRING, dir: oracledb.BIND_IN },
157+
o: { type: oracledb.STRING, dir: oracledb.BIND_OUT }
158+
};
159+
sql.executeSqlWithErr(connection, fun_execute, bindVar, {}, function(err) {
160+
(err.message).should.startWith("ORA-01410:");
161+
// ORA-01410: invalid ROWID
162+
done();
163+
});
155164
});
156165

157166
it('121.1.8 works with number 0', function(done) {
@@ -267,9 +276,18 @@ describe('121. urowidFunctionBindAsString1.js', function() {
267276
funBindOut(fun_execute, content, content, done);
268277
});
269278

270-
it.skip('121.2.7 works with string 0', function(done) {
279+
it('121.2.7 works with string 0', function(done) {
271280
var content = "0";
272-
funBindOut(fun_execute, content, "00000000.0000.0000", done);
281+
var bindVar = {
282+
i: { val: insertID, type: oracledb.NUMBER, dir: oracledb.BIND_IN },
283+
c: { val: content, type: oracledb.STRING, dir: oracledb.BIND_IN },
284+
o: { type: oracledb.STRING, dir: oracledb.BIND_OUT }
285+
};
286+
sql.executeSqlWithErr(connection, fun_execute, bindVar, {}, function(err) {
287+
(err.message).should.startWith("ORA-01410:");
288+
// ORA-01410: invalid ROWID
289+
done();
290+
});
273291
});
274292

275293
it('121.2.8 works with number 0', function(done) {
@@ -366,10 +384,23 @@ describe('121. urowidFunctionBindAsString1.js', function() {
366384
funBindOut_update(fun_exec, content_1, content_2, content_2, done);
367385
});
368386

369-
it.skip('121.3.4 works with default bind type/dir', function(done) {
387+
it('121.3.4 works with default bind type/dir', function(done) {
370388
var content_1 = "AAAB1+AADAAAAwPAAA";
371389
var content_2 = "0";
372-
funBindOut_update(fun_exec, content_1, content_2, "00000000.0000.0000", done);
390+
//funBindOut_update(fun_exec, content_1, content_2, "00000000.0000.0000", done);
391+
392+
var bindVar = {
393+
i: { val: insertID, type: oracledb.NUMBER, dir: oracledb.BIND_IN },
394+
c1: { val: content_1, type: oracledb.STRING, dir: oracledb.BIND_IN },
395+
c2: { val: content_2, type: oracledb.STRING, dir: oracledb.BIND_IN },
396+
o: { type: oracledb.STRING, dir: oracledb.BIND_OUT }
397+
};
398+
399+
sql.executeSqlWithErr(connection, fun_exec, bindVar, {}, function(err) {
400+
(err.message).should.startWith("ORA-01410:");
401+
// ORA-01410: invalid ROWID
402+
done();
403+
});
373404
});
374405

375406
it('121.3.5 works with default bind type/dir - null value', function(done) {

‎test/urowidFunctionBindAsString2.js

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,19 @@ describe('122. urowidFunctionBindAsString2.js', function() {
150150
funBindInOut(fun_execute, content, content, done);
151151
});
152152

153-
it.skip('122.1.7 works with string 0', function(done) {
153+
it('122.1.7 works with string 0', function(done) {
154154
var content = "0";
155-
funBindInOut(fun_execute, content, "00000000.0000.0000", done);
155+
156+
var bindVar = {
157+
i: { val: insertID, type: oracledb.NUMBER, dir: oracledb.BIND_IN },
158+
c: { val: content, type: oracledb.STRING, dir: oracledb.BIND_INOUT },
159+
o: { type: oracledb.STRING, dir: oracledb.BIND_OUT }
160+
};
161+
sql.executeSqlWithErr(connection, fun_execute, bindVar, {}, function(err) {
162+
(err.message).should.startWith("ORA-01410:");
163+
// ORA-01410: invalid ROWID
164+
done();
165+
});
156166
});
157167

158168
it('122.1.8 works with number 0', function(done) {
@@ -369,10 +379,21 @@ describe('122. urowidFunctionBindAsString2.js', function() {
369379
funBindInOut_update(fun_execute, content_1, content_2, content_2, done);
370380
});
371381

372-
it.skip('122.3.4 works with default bind type/dir', function(done) {
382+
it('122.3.4 works with default bind type/dir', function(done) {
373383
var content_1 = "AAAB1+AADAAAAwPAAA";
374384
var content_2 = "0";
375-
funBindInOut_update(fun_execute, content_1, content_2, "00000000.0000.0000", done);
385+
var bindVar = {
386+
i: { val: insertID, type: oracledb.NUMBER, dir: oracledb.BIND_IN },
387+
c1: { val: content_1, type: oracledb.STRING, dir: oracledb.BIND_INOUT },
388+
c2: { val: content_2, type: oracledb.STRING, dir: oracledb.BIND_INOUT },
389+
o: { type: oracledb.STRING, dir: oracledb.BIND_OUT }
390+
};
391+
392+
sql.executeSqlWithErr(connection, fun_execute, bindVar, {}, function(err) {
393+
(err.message).should.startWith("ORA-01410:");
394+
// ORA-01410: invalid ROWID
395+
done();
396+
});
376397
});
377398

378399
it('122.3.5 works with default bind type/dir - null value', function(done) {

‎test/urowidProcedureBindAsString1.js

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,17 @@ describe('118. urowidProcedureBindAsString1.js', function() {
145145
procedureBindIn(proc_execute, content, content, done);
146146
});
147147

148-
it.skip('118.1.7 works with string 0', function(done) {
148+
it('118.1.7 works with string 0', function(done) {
149149
var content = "0";
150-
procedureBindIn(proc_execute, content, "00000000.0000.0000", done);
150+
var bindVar = {
151+
i: { val: insertID, type: oracledb.NUMBER, dir: oracledb.BIND_IN },
152+
c: { val: content, type: oracledb.STRING, dir: oracledb.BIND_IN }
153+
};
154+
sql.executeSqlWithErr(connection, proc_execute, bindVar, {}, function(err) {
155+
(err.message).should.startWith("ORA-01410:");
156+
// ORA-01410: invalid ROWID
157+
done();
158+
});
151159
});
152160

153161
it('118.1.8 works with number 0', function(done) {
@@ -350,10 +358,19 @@ describe('118. urowidProcedureBindAsString1.js', function() {
350358
procedureBindIn_update(proc_execute, content_1, content_2, content_2, done);
351359
});
352360

353-
it.skip('118.3.4 works with default bind type/dir', function(done) {
361+
it('118.3.4 works with default bind type/dir', function(done) {
354362
var content_1 = "AAAB1+AADAAAAwPAAA";
355363
var content_2 = "0";
356-
procedureBindIn_update(proc_execute, content_1, content_2, "00000000.0000.0000", done);
364+
var bindVar = {
365+
i: { val: insertID, type: oracledb.NUMBER, dir: oracledb.BIND_IN },
366+
c1: { val: content_1, type: oracledb.STRING, dir: oracledb.BIND_IN },
367+
c2: { val: content_2, type: oracledb.STRING, dir: oracledb.BIND_IN }
368+
};
369+
sql.executeSqlWithErr(connection, proc_execute, bindVar, {}, function(err) {
370+
(err.message).should.startWith("ORA-01410:");
371+
// ORA-01410: invalid ROWID
372+
done();
373+
});
357374
});
358375

359376
it('118.3.5 works with default bind type/dir - null value', function(done) {

‎test/urowidProcedureBindAsString2.js

Lines changed: 36 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,18 @@ describe('119. urowidProcedureBindAsString2.js', function() {
147147
procedureBindOut(proc_execute, content, content, done);
148148
});
149149

150-
it.skip('119.1.7 works with string 0', function(done) {
150+
it('119.1.7 works with string 0', function(done) {
151151
var content = "0";
152-
procedureBindOut(proc_execute, content, "00000000.0000.0000", done);
152+
var bindVar = {
153+
i: { val: insertID, type: oracledb.NUMBER, dir: oracledb.BIND_IN },
154+
c: { val: content, type: oracledb.STRING, dir: oracledb.BIND_IN },
155+
o: { type: oracledb.STRING, dir: oracledb.BIND_OUT }
156+
};
157+
sql.executeSqlWithErr(connection, proc_execute, bindVar, {}, function(err) {
158+
(err.message).should.startWith("ORA-01410:");
159+
// ORA-01410: invalid ROWID
160+
done();
161+
});
153162
});
154163

155164
it('119.1.8 works with number 0', function(done) {
@@ -263,9 +272,18 @@ describe('119. urowidProcedureBindAsString2.js', function() {
263272
procedureBindOut(proc_execute, content, content, done);
264273
});
265274

266-
it.skip('119.2.7 works with string 0', function(done) {
275+
it('119.2.7 works with string 0', function(done) {
267276
var content = "0";
268-
procedureBindOut(proc_execute, content, "00000000.0000.0000", done);
277+
var bindVar = {
278+
i: { val: insertID, type: oracledb.NUMBER, dir: oracledb.BIND_IN },
279+
c: { val: content, type: oracledb.STRING, dir: oracledb.BIND_IN },
280+
o: { type: oracledb.STRING, dir: oracledb.BIND_OUT }
281+
};
282+
sql.executeSqlWithErr(connection, proc_execute, bindVar, {}, function(err) {
283+
(err.message).should.startWith("ORA-01410:");
284+
// ORA-01410: invalid ROWID
285+
done();
286+
});
269287
});
270288

271289
it('119.2.8 works with number 0', function(done) {
@@ -360,10 +378,22 @@ describe('119. urowidProcedureBindAsString2.js', function() {
360378
procedureBindOut_update(proc_execute, content_1, content_2, content_2, done);
361379
});
362380

363-
it.skip('119.3.4 works with default bind type/dir', function(done) {
381+
it('119.3.4 works with default bind type/dir', function(done) {
364382
var content_1 = "AAAB1+AADAAAAwPAAA";
365383
var content_2 = "0";
366-
procedureBindOut_update(proc_execute, content_1, content_2, "00000000.0000.0000", done);
384+
385+
var bindVar = {
386+
i: { val: insertID, type: oracledb.NUMBER, dir: oracledb.BIND_IN },
387+
c1: { val: content_1, type: oracledb.STRING, dir: oracledb.BIND_IN },
388+
c2: { val: content_2, type: oracledb.STRING, dir: oracledb.BIND_IN },
389+
o: { type: oracledb.STRING, dir: oracledb.BIND_OUT }
390+
};
391+
392+
sql.executeSqlWithErr(connection, proc_execute, bindVar, {}, function(err) {
393+
(err.message).should.startWith("ORA-01410:");
394+
// ORA-01410: invalid ROWID
395+
done();
396+
});
367397
});
368398

369399
it('119.3.5 works with default bind type/dir - null value', function(done) {

‎test/urowidProcedureBindAsString3.js

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,17 @@ describe('120. urowidProcedureBindAsString3.js', function() {
146146
procedureBindInout(proc_execute, content, content, done);
147147
});
148148

149-
it.skip('120.1.7 works with string 0', function(done) {
149+
it('120.1.7 works with string 0', function(done) {
150150
var content = "0";
151-
procedureBindInout(proc_execute, content, "00000000.0000.0000", done);
151+
var bindVar = {
152+
i: { val: insertID, type: oracledb.NUMBER, dir: oracledb.BIND_IN },
153+
c: { val: content, type: oracledb.STRING, dir: oracledb.BIND_INOUT, maxSize: 1000 }
154+
};
155+
sql.executeSqlWithErr(connection, proc_execute, bindVar, {}, function(err) {
156+
(err.message).should.startWith("ORA-01410:");
157+
// ORA-01410: invalid ROWID
158+
done();
159+
});
152160
});
153161

154162
it('120.1.8 works with number 0', function(done) {
@@ -354,10 +362,21 @@ describe('120. urowidProcedureBindAsString3.js', function() {
354362
procedureBindInout_update(proc_execute, content_1, content_2, content_2, done);
355363
});
356364

357-
it.skip('120.3.4 works with default bind type/dir', function(done) {
365+
it('120.3.4 works with default bind type/dir', function(done) {
358366
var content_1 = "AAAB1+AADAAAAwPAAA";
359367
var content_2 = "0";
360-
procedureBindInout_update(proc_execute, content_1, content_2, "0", done);
368+
369+
var bindVar = {
370+
i: { val: insertID, type: oracledb.NUMBER, dir: oracledb.BIND_IN },
371+
c1: { val: content_1, type: oracledb.STRING, dir: oracledb.BIND_INOUT, maxSize: 1000 },
372+
c2: { val: content_2, type: oracledb.STRING, dir: oracledb.BIND_INOUT, maxSize: 1000 }
373+
};
374+
375+
sql.executeSqlWithErr(connection, proc_execute, bindVar, {}, function(err) {
376+
(err.message).should.startWith("ORA-01410:");
377+
// ORA-01410: invalid ROWID
378+
done();
379+
});
361380
});
362381

363382
it('120.3.5 works with default bind type/dir - null value', function(done) {

0 commit comments

Comments
 (0)