Internal code optimizations and documentation updates

Author: sharadraju

doc/src/release_notes.rst

@@ -38,10 +38,10 @@ Thick Mode Changes
     Additionally, this fix resolves the issue related to JS numbers with
     precisions where `2.3` is returned as `2.300003`.
 
-#) Fixed a regression that caused ``deqOne()``and ``deqMany()`` to return an
-   invalid object in 6.4 instead of undefined, which was returned in the
-   previous releases.
-   See `Issue #1656 <https://github.com/oracle/node-oracledb/issues/1656>`__.
+#)  Fixed a regression that caused :meth:`~aqQueue.deqOne()` and
+    :meth:`~aqQueue.deqMany()` to return an invalid object in node-oracledb
+    6.4 instead of undefined, which was returned in the previous releases.
+    See `Issue #1656 <https://github.com/oracle/node-oracledb/issues/1656>`__.
 
 node-oracledb `v6.4.0 <https://github.com/oracle/node-oracledb/compare/v6.3.0...v6.4.0>`__ (11 Mar 2024)
 --------------------------------------------------------------------------------------------------------

lib/thin/protocol/utils.js

@@ -52,30 +52,23 @@ function encodeRowID(rowID) {
   }
 }
 
-// obfuscate value and clear memory for Buffers as they are from Buffer pool
-// and are possible to stay longer
+// obfuscate value
 function setObfuscatedValue(value) {
-  const buf = crypto.randomBytes(Buffer.byteLength(value));
-  const bytes = Buffer.from(value, 'utf8');
-  const len = Buffer.byteLength(value);
-
-  const arr = [];
-  for (let i = 0; i < len; i++) {
-    arr.push(buf[i] ^ bytes[i]);
+  const valueBytes = Buffer.from(value);
+  const obfuscatedBytes = crypto.randomBytes(valueBytes.length);
+  for (let i = 0; i < valueBytes.length; i++) {
+    valueBytes[i] = obfuscatedBytes[i] ^ valueBytes[i];
   }
-  bytes.fill(0);
-  return {obfuscatedValue: buf, value: arr};
+  return {obfuscatedValue: obfuscatedBytes, value: valueBytes};
 }
 
-// returns the Deobfuscated value, after removing the obfuscation
+// returns the deobfuscated value, after removing the obfuscation
 // and clear memory of temporary Buffers coming from Buffer pool
-function getDeobfuscatedValue(value, obfuscatedValue) {
-  const arr = [];
-  for (let i = 0; i < value.length; i++) {
-    arr.push(value[i] ^ obfuscatedValue[i]);
+function getDeobfuscatedValue(valueBytes, obfuscatedBytes) {
+  const buf = Buffer.from(valueBytes);
+  for (let i = 0; i < valueBytes.length; i++) {
+    buf[i] = valueBytes[i] ^ obfuscatedBytes[i];
   }
-  const buf = Buffer.from(arr);
-  arr.fill(0);
   const retVal = buf.toString();
   buf.fill(0);
   return retVal;