Skip to content

Commit 0c62081

Browse files
committed
Fix character set initialization broken in d3bc2cd. Re-enable tests
1 parent 4cd19d3 commit 0c62081

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/njs/src/njsOracle.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,8 @@ Nan::Persistent<FunctionTemplate> Oracledb::oracledbTemplate_s;
7878
*/
7979
Oracledb::Oracledb()
8080
{
81-
dpienv_ = dpi::Env::createEnv( driverName() );
81+
dpienv_ = dpi::Env::createEnv( driverName(), DPI_AL32UTF8,
82+
DPI_AL32UTF8 );
8283
outFormat_ = NJS_ROWS_ARRAY;
8384
maxRows_ = NJS_MAX_ROWS;
8485
autoCommit_ = false;

test/binding.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -629,7 +629,7 @@ describe('4. binding.js', function() {
629629
}
630630
);
631631
},
632-
/*function(callback) {
632+
function(callback) {
633633
connection.execute(
634634
"BEGIN nodb_testproc(:o); END;",
635635
[
@@ -643,7 +643,7 @@ describe('4. binding.js', function() {
643643
callback();
644644
}
645645
);
646-
},*/
646+
},
647647
function(callback) {
648648
connection.execute(
649649
"DROP PROCEDURE nodb_testproc",
@@ -668,7 +668,7 @@ describe('4. binding.js', function() {
668668
);
669669
})
670670

671-
it.skip('4.4.3 Negative - bind out data exceeds default length', function(done) {
671+
it('4.4.3 Negative - bind out data exceeds default length', function(done) {
672672
connection.execute(
673673
"BEGIN :o := lpad('A',201,'x'); END;",
674674
{ o: { type: oracledb.STRING, dir : oracledb.BIND_OUT } },

0 commit comments

Comments
 (0)