Skip to content

Commit 0e400b9

Browse files
committed
Add NJS-106 error message for Thick mode-related errors
1 parent 144c186 commit 0e400b9

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

doc/src/release_notes.rst

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ Thin Mode Changes
3131
#) Fixed issue that does not throw Authentication error for FastAuth
3232
when invalid token is used with external authentication.
3333

34-
#) Added connection optimization feature which uses Server Name Indication (SNI)
35-
extension of the TLS protocol.
34+
#) Added connection optimization feature which uses
35+
Server Name Indication (SNI) extension of the TLS protocol.
3636

3737
#) Added support for setting the :attr:`~oracledb.edition` when connecting to
3838
the database.
@@ -43,6 +43,11 @@ Thin Mode Changes
4343
#) Fixed bug with :meth:`dbObject.deleteElement()` which did not update the
4444
keys of associative arrays when an element was deleted.
4545

46+
Thick Mode Changes
47+
++++++++++++++++++
48+
49+
#) Internal error handling improvements.
50+
4651
node-oracledb `v6.7.1 <https://github.com/oracle/node-oracledb/compare/v6.7.0...v6.7.1>`__ (23 Dec 2024)
4752
---------------------------------------------------------------------------------------------------------
4853

src/njsModule.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,8 @@
172172
"NJS-078: unsupported data type %d in JSON value"
173173
#define NJS_ERR_VECTOR_FORMAT_NOT_SUPPORTED \
174174
"NJS-144: VECTOR format %d is not supported"
175+
#define NJS_ERR_INTERNAL \
176+
"NJS-106: internal error: "
175177

176178
// pool statuses
177179
#define NJS_POOL_STATUS_OPEN 6000

src/njsUtils.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ bool njsUtils_genericThrowError(napi_env env, const char *fileName,
233233
if (!errorMessage)
234234
errorMessage = "no error message";
235235
(void) snprintf(internalError, sizeof(internalError),
236-
"internal error in file %s, line %d (%s)", fileName, lineNum,
236+
" %sin file %s, line %d (%s)", NJS_ERR_INTERNAL, fileName, lineNum,
237237
errorMessage);
238238
napi_throw_error(env, NULL, internalError);
239239
}

0 commit comments

Comments
 (0)