Skip to content

Commit 0ff932d

Browse files
committed
Reduce visual clutter: remove successful code path messages that haven't been helpful for problem solving
1 parent ead7641 commit 0ff932d

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

package/oracledbinstall.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ function verifyBinary() {
151151
return new Promise((resolve, reject) => {
152152
packageUtil.trace('In verifyBinary');
153153
packageUtil.trace('Checking for binary at', packageUtil.BINARY_PATH_LOCAL);
154-
packageUtil.log('Verifying installation');
155154

156155
if (!fs.existsSync(packageUtil.BINARY_PATH_LOCAL)) {
157156
resolve(false);
@@ -191,8 +190,6 @@ function verifyBinary() {
191190

192191
resolve(false);
193192
} else {
194-
packageUtil.log('Binary SHA matches SHA in SHASUMS256.txt');
195-
196193
resolve(true);
197194
}
198195
})
@@ -407,7 +404,7 @@ function done(err, alreadyInstalled) {
407404
}
408405

409406
packageUtil.log('**');
410-
packageUtil.log('** To use the installed node-oracledb:');
407+
packageUtil.log('** To use node-oracledb:');
411408

412409
if (process.platform === 'linux') {
413410
if (process.arch === 'x64') {
@@ -445,8 +442,9 @@ function done(err, alreadyInstalled) {
445442
}
446443

447444
packageUtil.log('**');
448-
packageUtil.log('** Node-oracledb installation instructions: ' + installUrl);
445+
packageUtil.log('** Installation instructions: ' + installUrl);
449446
packageUtil.log('********************************************************************************\n');
447+
packageUtil.log('');
450448
}
451449
}
452450

@@ -468,8 +466,6 @@ function install() {
468466
if (valid) {
469467
done(null, true);
470468
} else {
471-
packageUtil.log('Continuing installation');
472-
473469
return new Promise((resolve, reject) => {
474470
installBinary()
475471
.then(() => {

0 commit comments

Comments
 (0)