Fix external authentication. Fix mem leaks with DATE/TIMESTAMP binds

Author: cjbj

src/njs/src/njsConnection.cpp

@@ -1725,6 +1725,7 @@ void Connection::Async_Execute (uv_work_t *req)
        {
          bind->dttmarr->release () ;
          bind->dttmarr = NULL;
+         bind->value = NULL;
        }
      }
 
@@ -2628,6 +2629,7 @@ NJSErrorType Connection::Descr2Double( Define* defines, unsigned int numCols,
         if ( !getRS )
         {
           defines[col].dttmarr->release ();
+          defines[col].dttmarr = NULL;
           defines[col].extbuf = NULL;
         }
       }

src/njs/src/njsConnection.h

@@ -235,30 +235,26 @@ typedef struct eBaton
      {
        for( unsigned int index = 0 ;index < binds.size(); index++ )
        {
-         // donot free date value here, it is done in DateTimeArray functions
-         if(binds[index]->type != DpiTimestampLTZ )
+         // do not free refcursor type.
+         if( binds[index]->value && binds[index]->type != DpiRSet )
          {
-           // do not free refcursor type.
-           if( binds[index]->value && binds[index]->type != DpiRSet )
-           {
-             free(binds[index]->value);
-           }
-           if ( binds[index]->extvalue )
-           {
-             free ( binds[index]->extvalue );
-           }
-           if ( binds[index]->ind )
-           {
-             free ( binds[index]->ind );
-           }
-           if ( binds[index]->len )
-           {
-             free ( binds[index]->len );
-           }
-           if ( binds[index]->len2 )
-           {
-             free ( binds[index]->len2 ) ;
-           }
+           free(binds[index]->value);
+         }
+         if ( binds[index]->extvalue )
+         {
+           free ( binds[index]->extvalue );
+         }
+         if ( binds[index]->ind )
+         {
+           free ( binds[index]->ind );
+         }
+         if ( binds[index]->len )
+         {
+           free ( binds[index]->len );
+         }
+         if ( binds[index]->len2 )
+         {
+           free ( binds[index]->len2 ) ;
          }
          delete binds[index];
        }

src/njs/src/njsOracle.cpp

@@ -989,6 +989,8 @@ void Oracledb::Async_CreatePool (uv_work_t *req)
 
   try
   {
+    // externAuth is not supported in homogeneous pool, in case app specified
+    // externalAuth, then make it as heterogeneous pool.
     poolBaton->dpipool = poolBaton-> dpienv ->
                                      createPool ( poolBaton->user,
                                                   poolBaton->pswrd,
@@ -998,7 +1000,8 @@ void Oracledb::Async_CreatePool (uv_work_t *req)
                                                   poolBaton->poolIncrement,
                                                   poolBaton->poolTimeout,
                                                   poolBaton->stmtCacheSize,
-                                                  poolBaton->externalAuth );
+                                                  poolBaton->externalAuth,
+                                   poolBaton->externalAuth ? false : true  );
   }
   catch (dpi::Exception &e)
   {