Skip to content

Commit 252acce

Browse files
committed
Note that the locally hosted binary installs need the tag in the URL
1 parent d18b4da commit 252acce

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

package/Makefile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,10 @@ PAT=$(shell grep '\#define \+NJS_NODE_ORACLEDB_PATCH' ../src/njsOracle.h | sed -
1919
VER=$(MAJ).$(MIN).$(PAT)
2020

2121
# The staging-oracledb-X.Y.Z.tgz package will try to download binaries from
22-
# https://$NODE_ORACLEDB_PACKAGE_HOSTNAME/$NODE_ORACLEDB_PACKAGE_URL_PATH/
22+
# https://$NODE_ORACLEDB_PACKAGE_HOSTNAME/$NODE_ORACLEDB_PACKAGE_URL_PATH/vX.Y.Z/
2323
ifndef NODE_ORACLEDB_PACKAGE_HOSTNAME
2424
NODE_ORACLEDB_PACKAGE_HOSTNAME='your-staging-server.example.com'
2525
endif
26-
2726
ifndef NODE_ORACLEDB_PACKAGE_URL_PATH
2827
NODE_ORACLEDB_PACKAGE_URL_PATH='/your-url-path-to-directory/'
2928
endif

package/README.md

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -70,21 +70,24 @@ Installation is described in [INSTALL](../INSTALL.md).
7070
`NODE_ORACLEDB_PACKAGE_URL_PATH` (e.g. "/yourpath/") which must be set
7171
before running `make`.
7272

73-
You can use `staging-oracledb-X.Y.Z.tgz` to host binaries on your
74-
own network. Copy `staging-oracledb-X.Y.Z.tgz`, the binary packages
75-
for each desired architectures, and a single SHASUMS256.txt file
76-
(with one line per available binary package) to an HTTPS-enabled web
77-
server. Note if the web server has a self-signed certificate, then
78-
before running `npm install
79-
https://your.example.com/yourpath/staging-oracledb-X.Y.X.tgz` you
80-
may need to set:
73+
- The`staging-oracledb-X.Y.Z.tgz` package can be used to host binaries
74+
on internal networks. Copy `staging-oracledb-X.Y.Z.tgz`, the binary
75+
packages for each desired architectures, and a single SHASUMS256.txt
76+
file (with one line per available binary package) to an
77+
HTTPS-enabled web server to the directory that
78+
https://your.example.com/yourpath/vX.Y.Z/ resolves to. Note if the
79+
web server has a self-signed certificate, then you you may need to
80+
bypass some npm checks:
8181

8282
```
8383
export NODE_TLS_REJECT_UNAUTHORIZED=0
8484
npm config set strict-ssl false
85+
86+
npm install https://your.example.com/yourpath/vX.Y.Z/staging-oracledb-X.Y.X.tgz
8587
```
8688

87-
Remember to do `npm config delete strict-ssl` when not testing.
89+
Remember to do `npm config delete strict-ssl` and unset the
90+
environment variable when not testing.
8891

8992
- At install time, setting the environment variable
9093
`NODE_ORACLEDB_TRACE_INSTALL` to `TRUE` will cause `npm install` to

0 commit comments

Comments
 (0)