Skip to content

Commit 2ed22bb

Browse files
committed
Changed the password type parameter values to ocivault and azurevault respectively for consistency with other Oracle Database drivers
1 parent 41a1e15 commit 2ed22bb

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

doc/src/release_notes.rst

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,17 @@ Common Changes
1616
Thin Mode Changes
1717
+++++++++++++++++
1818

19-
#) Added support for fetching the list of network service names from
20-
tnsnames.ora using a new method, oracledb.getNetworkServiceNames()
19+
#) Changed the password type parameter values from `vault-oci` and
20+
`vault-azure` to `ocivault` and `azurevault` respectively for consistency
21+
with other Oracle Database drivers.
22+
23+
#) Added method :meth:`oracledb.getNetworkServiceNames()` to support fetching
24+
the list of network service names from the ``tnsnames.ora`` file.
2125

2226
#) Fixed bug that did not allow connection to Oracle Database 23ai instances
2327
that have fast authentication disabled.
2428

25-
#) Fixed bug with statement cache which threw an `NJS-111` error when select
29+
#) Fixed bug with statement cache which threw an ``NJS-111`` error when select
2630
SQL is run on CLOB columns fetched as string.
2731
See `Issue #1684 <https://github.com/oracle/node-oracledb/issues/
2832
1684>`__.

lib/configProviders/ociobject.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ class OCIProvider extends base {
155155
configObject.connectString = obj.connect_descriptor;
156156
configObject.user = obj.user;
157157
if (obj.password) {
158-
if (obj.password.type == "vault-azure") {
158+
if (obj.password.type == "azurevault") {
159159
if (obj.password.authentication) {
160160
const { SecretClient } = require("@azure/keyvault-secrets");
161161
const {ClientSecretCredential, ClientCertificateCredential} = require("@azure/identity");
@@ -171,7 +171,7 @@ class OCIProvider extends base {
171171
} else {
172172
errors.throwErr(errors.ERR_AZURE_VAULT_AUTH_FAILED);
173173
}
174-
} else if (obj.password.type == "vault-oci") {
174+
} else if (obj.password.type == "ocivault") {
175175
const secrets = require('oci-secrets');
176176
const secretClientOci = new secrets.SecretsClient({
177177
authenticationDetailsProvider: credential

0 commit comments

Comments
 (0)