Keep the method name in internally bound functions

Author: cjbj

CHANGELOG.md

@@ -4,6 +4,9 @@
 
 **This release is under development and information may be incomplete**
 
+- Added code to keep the method name in internally bound functions.
+  PR #1466 (Slawomir Osoba)
+
 - Added code to handle multiple out-binds with ([DbObject](https://oracle.github.io/node-oracledb/doc/api.html#dbobjectclass)) correctly, earlier only
   the first one was processed and was resulting in a crash.
   ([Issue #1464](https://github.com/oracle/node-oracledb/issues/1464))

lib/util.js

@@ -170,7 +170,7 @@ module.exports.checkArgCount = checkArgCount;
 // is resolved or rejected and the callback invoked; otherwise, the function is
 // called unchanged and a promise is returned
 function callbackify(func) {
-  return function() {
+  const wrapper = function() {
 
     // if last argument is not a function, simply invoke the function as usual
     // and a promise will be returned
@@ -186,6 +186,10 @@ function callbackify(func) {
     }, cb);
 
   };
+  if (func.name) {
+    Object.defineProperty(wrapper, 'name', { value: func.name });
+  }
+  return wrapper;
 }
 
 module.exports.callbackify = callbackify;

test/list.txt

@@ -5299,3 +5299,7 @@ oracledb.OUT_FORMAT_OBJECT and resultSet =  true
 
 262. dbObjectOutBind.js
     262.1 call procedure with 2 OUT binds of DbObject
+
+
+264. methodName.js
+    264.1 check for methodName getConnection

test/methodName.js

@@ -0,0 +1,40 @@
+/* Copyright (c) 2022, Oracle and/or its affiliates. */
+
+/******************************************************************************
+ *
+ * You may not use the identified files except in compliance with the Apache
+ * License, Version 2.0 (the "License.")
+ *
+ * You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * NAME
+ *   264. methodName.js
+ *
+ * DESCRIPTION
+ *   Test to verify the code to keep the method name in internally bound
+ *   functions.
+ *
+ *   Note: These tests uses additional file test/testMethodName.js which is
+ *         spawned and the output is compared.
+ *
+ *****************************************************************************/
+'use strict';
+
+const oracledb = require('oracledb');
+const assert   = require('assert');
+
+describe('264. methodName.js', () => {
+
+  it('264.1 check for methodName getConnection', function() {
+    assert.equal(oracledb.getConnection.name, 'bound getConnection');
+  });
+
+});

test/opts/.mocharc.yaml

@@ -248,4 +248,5 @@ spec:
   - test/tpc.js
   - test/tpcResume.js
   - test/connHealthy.js
-  - test/dbObjectOutBind.js
+  - test/dbObjectOutBind.js
+  - test/methodName.js