Skip to content

Commit 322e447

Browse files
committed
Change to use the default pool values so people who copy the script don't think they are recommendations
1 parent 6c904c2 commit 322e447

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

examples/webapp.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,17 +40,17 @@ var dbConfig = require('./dbconfig.js');
4040
var portid = 7000; // HTTP listening port number
4141

4242
// Main entry point. Creates a connection pool, on callback creates an
43-
// HTTP server and executes a query based on the URL parameter given
44-
// The pool values are arbitrary for the sake of showing how to set the properties.
43+
// HTTP server and executes a query based on the URL parameter given.
44+
// The pool values shown are the default values.
4545
oracledb.createPool (
4646
{
4747
user : dbConfig.user,
4848
password : dbConfig.password,
4949
connectString : dbConfig.connectString,
50-
poolMax : 44,
51-
poolMin : 2,
52-
poolIncrement : 5,
53-
poolTimeout : 4
50+
poolMax : 4, // maximum size of the pool
51+
poolMin : 0, // let the pool shrink completely
52+
poolIncrement : 1, // only grow the pool by one connection at a time
53+
poolTimeout : 0 // never terminate idle connections
5454
},
5555
function(err, pool)
5656
{

0 commit comments

Comments
 (0)