Skip to content

Commit 3ed7d4a

Browse files
committed
Prefer sed over Perl. Update quotes for correctness
1 parent 0a3213c commit 3ed7d4a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

package/Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ VER=$(MAJ).$(MIN).$(PAT)
2121
# The staging-oracledb-X.Y.Z.tgz package will try to download binaries from
2222
# https://$NODE_ORACLEDB_PACKAGE_HOSTNAME/$NODE_ORACLEDB_PACKAGE_URL_PATH/vX.Y.Z/
2323
ifndef NODE_ORACLEDB_PACKAGE_HOSTNAME
24-
NODE_ORACLEDB_PACKAGE_HOSTNAME='your-staging-server.example.com'
24+
NODE_ORACLEDB_PACKAGE_HOSTNAME=your-staging-server.example.com
2525
endif
2626
ifndef NODE_ORACLEDB_PACKAGE_URL_PATH
27-
NODE_ORACLEDB_PACKAGE_URL_PATH='/your-url-path-to-directory/'
27+
NODE_ORACLEDB_PACKAGE_URL_PATH=/your-url-path-to-directory/
2828
endif
2929

3030
# Create a package containing the binary and license files.
@@ -45,8 +45,8 @@ oracledb-$(VER).tgz:
4545
mkdir -m 755 bundle/package
4646
cp ./oracledbinstall.js ./extractpackage.js ./util.js bundle/package/
4747
(cd bundle && tar -czvf ../oracledb-$(VER).tgz ./*)
48-
perl -p -i -e "s#'github.com'#'$(NODE_ORACLEDB_PACKAGE_HOSTNAME)'#" bundle/package/oracledbinstall.js
49-
perl -p -i -e "s#'/oracle/node-oracledb/releases/download/'#'$(NODE_ORACLEDB_PACKAGE_URL_PATH)'#" bundle/package/oracledbinstall.js
48+
sed -e "s#'github.com'#'$(NODE_ORACLEDB_PACKAGE_HOSTNAME)'#" bundle/package/oracledbinstall.js > bundle/package/oracledbinstall.js.tmp && mv bundle/package/oracledbinstall.js.tmp bundle/package/oracledbinstall.js
49+
sed -e "s#'/oracle/node-oracledb/releases/download/'#'$(NODE_ORACLEDB_PACKAGE_URL_PATH)'#" bundle/package/oracledbinstall.js > bundle/package/oracledbinstall.js.tmp && mv bundle/package/oracledbinstall.js.tmp bundle/package/oracledbinstall.js
5050
(cd bundle && tar -czvf ../staging-oracledb-$(VER).tgz ./*)
5151
rm -rf ./bundle/
5252

0 commit comments

Comments
 (0)