Skip to content

Commit 47a883c

Browse files
committed
Fixed issue with connecting to Oracle Database, when the full path of the Node.js executable contains certain non-standard characters like '(' and ')'. (Issue #1664
1 parent 711f44f commit 47a883c

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

doc/src/release_notes.rst

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ Common Changes
3939

4040
Thin Mode Changes
4141
++++++++++++++++++
42+
#) Fixed issue with connecting to Oracle Database, when the full path of
43+
the Node.js executable contains certain non-standard characters like '(' and ')'.
44+
See `Issue #1644 <https://github.com/oracle/node-oracledb/issues/1664>`__.
4245

4346
#) Added support for easy connect string entries in tnsnames.ora
4447
See `Issue #1644 <https://github.com/oracle/node-oracledb/issues/1644>`__.

lib/thin/sqlnet/navNodes.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -777,7 +777,8 @@ class NavDescription extends Description {
777777
if (this.connectData == null) {
778778
this.connectData = "(SERVICE_NAME=)";
779779
}
780-
const cid = `(CID=(PROGRAM=${cInfo.program})(HOST=${cInfo.hostName})(USER=${cInfo.userName}))`;
780+
const pgmName = "\"'" + cInfo.program + "'\"";
781+
const cid = `(CID=(PROGRAM=${pgmName})(HOST=${cInfo.hostName})(USER=${cInfo.userName}))`;
781782
cOpts[i].CNdata.push(NavSchemaObject.CD);
782783
cOpts[i].CNdata.push(this.connectData);
783784
cOpts[i].CNdata.push(cid);

0 commit comments

Comments
 (0)