Error update for invalid POOL_BOUNDARY value with Implicit Connection Pooling

Author: sharadraju

lib/errors.js

@@ -144,7 +144,6 @@ const ERR_VECTOR_FORMAT_NOT_SUPPORTED = 144;
 const ERR_VECTOR_VERSION_NOT_SUPPORTED = 145;
 const ERR_OBJECT_IS_NOT_A_COLLECTION = 146;
 const ERR_CURSOR_HAS_BEEN_CLOSED = 147;
-const ERR_INVALID_POOL_BOUNDARY = 148;
 const ERR_DML_RETURNING_DUP_BINDS = 149;
 
 // Oracle Net layer errors start from 500
@@ -191,7 +190,6 @@ adjustErrorXref.set("ORA-00600", ERR_CONNECTION_CLOSED);
 adjustErrorXref.set("ORA-24338", ERR_INVALID_REF_CURSOR);
 adjustErrorXref.set("ORA-25708", ERR_TOKEN_HAS_EXPIRED);
 adjustErrorXref.set("ORA-24344", WRN_COMPILATION_CREATE);
-adjustErrorXref.set("ORA-24545", ERR_INVALID_POOL_BOUNDARY);
 
 // define mapping for error messages
 const messages = new Map();
@@ -423,8 +421,6 @@ messages.set(ERR_OBJECT_IS_NOT_A_COLLECTION,            // NJS-146
   'object %s is not a collection');
 messages.set(ERR_CURSOR_HAS_BEEN_CLOSED,                // NJS-147
   'cursor has been closed by the database');
-messages.set(ERR_INVALID_POOL_BOUNDARY,                 // NJS-148
-  'invalid value of POOL_BOUNDARY in connect string');
 messages.set(ERR_DML_RETURNING_DUP_BINDS,               // NJS-149
   'the bind variable placeholder "%s" cannot be used both before and after the RETURNING clause in a DML RETURNING statement');
 
@@ -819,7 +815,6 @@ module.exports = {
   ERR_VECTOR_VERSION_NOT_SUPPORTED,
   ERR_OBJECT_IS_NOT_A_COLLECTION,
   ERR_CURSOR_HAS_BEEN_CLOSED,
-  ERR_INVALID_POOL_BOUNDARY,
   ERR_DML_RETURNING_DUP_BINDS,
   ERR_CONNECTION_CLOSED_CODE: `${ERR_PREFIX}-${ERR_CONNECTION_CLOSED}`,
   WRN_COMPILATION_CREATE,

lib/thin/connection.js

@@ -632,7 +632,6 @@ class ThinConnectionImpl extends ConnectionImpl {
     this._drcpEnabled = false;
     this.serviceName = '';
     this.remoteAddress = '';
-    this.implicitPoolBoundary = null;
     this.comboKey = null; // used in changePassword API
 
     this.nscon = new nsi();
@@ -650,13 +649,9 @@ class ThinConnectionImpl extends ConnectionImpl {
       this.serviceName = this.nscon.getOption(sqlNetConstants.SVCNAME);
       this.sid = this.nscon.getOption(sqlNetConstants.SID);
       this.purity = this.nscon.getOption(sqlNetConstants.PURITY) | constants.PURITY_DEFAULT;
-      this.implicitPoolBoundary = this.nscon.getOption(sqlNetConstants.POOLBOUNDARY);
     }
     if (serverType) {
       this._drcpEnabled = serverType.toLowerCase() === 'pooled';
-      if (this._drcpEnabled) {
-        thinUtil.validateImplicitPoolBoundary(this.implicitPoolBoundary);
-      }
     }
     this.remoteAddress = this.nscon.getOption(sqlNetConstants.REMOTEADDR);
     this.connectionClass = params.connectionClass;

lib/thin/pool.js

@@ -128,12 +128,6 @@ class ThinPoolImpl extends PoolImpl {
       this._generateConnectionClass();
     }
 
-    // validate pool boundary for implicit pooling
-    this._implicitPoolBoundary = this._userConfig._connInfo[6];
-    if (this._isDRCPEnabled) {
-      thinUtil.validateImplicitPoolBoundary(this._implicitPoolBoundary);
-    }
-
     // create a background task. It will create minimum connections in the pool
     // and expand the pool as required.
     this.bgThreadFunc();

lib/thin/sqlnet/constants.js

@@ -197,7 +197,6 @@ module.exports =  {
   CONNCLASS: 7, // Connection Class
   PURITY: 8, // Purity
   SID: 9, // SID
-  POOLBOUNDARY: 10, // Pool Boundary for implicit pooling
 
   /* FLAGS */
   NSNOBLOCK: 0x0001, // Do not block

lib/thin/sqlnet/networkSession.js

@@ -58,9 +58,8 @@ async function getConnectionInfo(userConfig) {
   const svcname =   findValue(nvpair, ["DESCRIPTION", "CONNECT_DATA", "SERVICE_NAME"]);
   const sid =   findValue(nvpair, ["DESCRIPTION", "CONNECT_DATA", "SID"]);
   const poolPurity = findValue(nvpair, ["DESCRIPTION", "CONNECT_DATA", "POOL_PURITY"]);
-  const poolBoundary = findValue(nvpair, ["DESCRIPTION", "CONNECT_DATA", "POOL_BOUNDARY"]);
 
-  return [serverVal, connClass, svcname, poolPurity, sid, addressNode, poolBoundary];
+  return [serverVal, connClass, svcname, poolPurity, sid, addressNode];
 }
 
 /**
@@ -599,9 +598,6 @@ class NetworkSession {
       case constants.HEALTHCHECK: /* Is connection healthy */
         return (this.connected && this.ntAdapter.connected && !this.ntAdapter.err);
 
-      case constants.POOLBOUNDARY: /* Pool Boundary */
-        return findValue(this.cDataNVPair, ["DESCRIPTION", "CONNECT_DATA", "POOL_BOUNDARY"]);
-
       default:
         errors.throwErr(errors.ERR_INTERNAL, "getOption not supported for opcode " + opcode);
     }

lib/thin/util.js

@@ -238,18 +238,6 @@ function checkCredentials(params) {
   }
 }
 
-//---------------------------------------------------------------------------
-// validateImplicitPoolBoundary()
-//
-// validate POOL_BOUNDARY parameter value
-//---------------------------------------------------------------------------
-function validateImplicitPoolBoundary(value) {
-  if (value != null && String(value.toLowerCase()) !== 'statement' &&
-    String(value.toLowerCase()) !== 'transaction') {
-    errors.throwErr(errors.ERR_INVALID_POOL_BOUNDARY);
-  }
-}
-
 //---------------------------------------------------------------------------
 // normalizePrivateKey()
 //
@@ -267,5 +255,4 @@ module.exports = {
   checkProxyUserValidity,
   checkCredentials,
   normalizePrivateKey,
-  validateImplicitPoolBoundary
 };