Skip to content

Commit 4dd000f

Browse files
committed
Fix terminology
1 parent 3bafac7 commit 4dd000f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,7 @@ and
519519

520520
- Fixed some SODA stability issues (node-oracledb and ODPI-C changes).
521521

522-
- Improved the statement error white list to avoid unnecessarily
522+
- Improved the statement error Allow List to avoid unnecessarily
523523
dropping statements from the statement cache (ODPI-C change).
524524

525525
- Made internal changes to fix V8 deprecation compilation warnings

examples/sessiontagging2.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ const httpPort = 7000;
5757
//
5858
// This implementation assumes the tag has name-value pairs like
5959
// "k1=v1;k2=v2" where the pairs can be used in an ALTER SESSION
60-
// statement. Specifically it white lists TIME_ZONE=UTC and
61-
// TIME_ZONE=Australia/Melbourne. The white list could be enhanced to
60+
// statement. Specifically it allows TIME_ZONE=UTC and
61+
// TIME_ZONE=Australia/Melbourne. The Allow List could be enhanced to
6262
// support more settings. Another potential improvement would be to
6363
// identify properties in connection.tag that were not specifically
6464
// asked for in requestedTag. These can be reset, as needed.
@@ -89,7 +89,7 @@ function initSession(connection, requestedTag, cb) {
8989
}
9090
}
9191

92-
// Check allowed values against a white list to avoid any SQL
92+
// Check allowed values against an Allow List to avoid any SQL
9393
// injection issues. Construct a string of valid options usable by
9494
// ALTER SESSION.
9595
let s = "";
@@ -103,7 +103,7 @@ function initSession(connection, requestedTag, cb) {
103103
cb(new Error(`Error: Invalid time zone value ${requestedProperties[k]}`));
104104
return;
105105
}
106-
// add white listing code to check other properties and values here
106+
// add Allow Listing code to check other properties and values here
107107
} else {
108108
cb(new Error(`Error: Invalid connection tag property ${k}`));
109109
return;

0 commit comments

Comments
 (0)