Add PL/SQL Index-by array test

Author: cjbj

test/plsqlBinding1.js

@@ -64,7 +64,7 @@ describe('43. plsqlBinding1.js', function() {
       });
     })
 
-    it('43.1.1 binding PL/SQL indexed table IN', function(done) {
+    it('43.1.1 binding PL/SQL indexed table IN by name', function(done) {
       async.series([
         function(callback) {
           var proc = "CREATE OR REPLACE PACKAGE\n" +
@@ -138,7 +138,77 @@ describe('43. plsqlBinding1.js', function() {
       ], done);
     });
 
-    it('43.1.2 binding PL/SQL indexed table IN OUT', function(done) {
+    it('43.1.2 binding PL/SQL indexed table IN by position', function(done) {
+      async.series([
+        function(callback) {
+          var proc = "CREATE OR REPLACE PACKAGE\n" +
+                      "oracledb_testpack\n" +
+                      "IS\n" +
+                      "  TYPE stringsType IS TABLE OF VARCHAR2(30) INDEX BY BINARY_INTEGER;\n" +
+                      "  TYPE numbersType IS TABLE OF NUMBER INDEX BY BINARY_INTEGER;\n" +
+                      "  PROCEDURE test(s IN stringsType, n IN numbersType);\n" +
+                      "END;";
+          connection.should.be.ok;
+          connection.execute(
+            proc,
+            function(err) {
+              should.not.exist(err);
+              callback();
+            }
+          );
+        },
+        function(callback) {
+          var proc = "CREATE OR REPLACE PACKAGE BODY\n" +
+                     "oracledb_testpack\n" +
+                     "IS\n" +
+                     "  PROCEDURE test(s IN stringsType, n IN numbersType)\n" +
+                     "  IS\n" +
+                     "  BEGIN\n" +
+                     "    IF (s(1) IS NULL OR s(1) <> 'John') THEN\n" +
+                     "      raise_application_error(-20000, 'Invalid s(1): \"' || s(1) || '\"');\n" +
+                     "    END IF;\n" +
+                     "    IF (s(2) IS NULL OR s(2) <> 'Doe') THEN\n" +
+                     "      raise_application_error(-20000, 'Invalid s(2): \"' || s(2) || '\"');\n" +
+                     "    END IF;\n" +
+                     "  END;\n" +
+                     "END;";
+          connection.should.be.ok;
+          connection.execute(
+            proc,
+            function(err) {
+              should.not.exist(err);
+              callback();
+            }
+          );
+        },
+        function(callback) {
+          var bindvars = [
+            {type: oracledb.STRING, dir: oracledb.BIND_IN, val: ['John', 'Doe']},
+            {type: oracledb.NUMBER, dir: oracledb.BIND_IN, val: [8, 11]}
+          ];
+          connection.execute(
+            "BEGIN oracledb_testpack.test(:1, :2); END;",
+            bindvars,
+            function(err, result) {
+              should.not.exist(err);
+              // console.log(result);
+              callback();
+            }
+          );
+        },
+        function(callback) {
+          connection.execute(
+            "DROP PACKAGE oracledb_testpack",
+            function(err) {
+              should.not.exist(err);
+              callback();
+            }
+          );
+        }
+      ], done);
+    });
+
+    it('43.1.3 binding PL/SQL indexed table IN OUT', function(done) {
       async.series([
         function(callback) {
           var proc = "CREATE OR REPLACE PACKAGE\n" +
@@ -211,7 +281,7 @@ describe('43. plsqlBinding1.js', function() {
       ], done);
     });
 
-    it('43.1.3 binding PL/SQL indexed table OUT', function(done) {
+    it('43.1.4 binding PL/SQL indexed table OUT', function(done) {
       async.series([
         function(callback) {
           var proc = "CREATE OR REPLACE PACKAGE\n" +
@@ -469,9 +539,8 @@ describe('43. plsqlBinding1.js', function() {
         "BEGIN oracledb_testpack.test4(:1); END;",
         bindvars,
         function(err, result) {
-          should.exist(err);
-          (err.message).should.startWith('ORA-06550');  // this causes a PL/SQL syntax error
-          should.not.exist(result);
+          should.not.exist(err);
+          should.exist(result);
           done();
         }
       );