Raise error if the batcherrors exceeds 655535 for executeMany function in Thin mode

Author: sharadraju

doc/src/release_notes.rst

@@ -7,6 +7,25 @@ node-oracledb Release Notes
 
 For deprecated and desupported features, see :ref:`Deprecations and desupported features <deprecations>`.
 
+node-oracledb `v6.4.0 <https://github.com/oracle/node-oracledb/compare/v6.3.0...v6.4.0>`__ (TBD)
+--------------------------------------------------------------------------------------------------------
+
+Common Changes
+++++++++++++++
+
+Thin Mode Changes
+++++++++++++++++++
+
+#)  Error ``NJS-141: errors in array DML exceed 65535`` is now raised
+    when the number of batch errors exceed 65535 when calling
+    :meth:`connection.executeMany()` with the parameter ``batchErrors``
+    set to the value `true`. Note that in thick mode, this error is not raised
+    unless the number of batch errors is a multiple of 65536; instead,
+    the number of batch errors returned is modulo 65536.
+
+Thick Mode Changes
+++++++++++++++++++
+
 node-oracledb `v6.3.0 <https://github.com/oracle/node-oracledb/compare/v6.2.0...v6.3.0>`__ (21 Dec 2023)
 --------------------------------------------------------------------------------------------------------
 

lib/errors.js

@@ -138,6 +138,7 @@ const ERR_MISSING_BIND_VALUE = 137;
 const ERR_SERVER_VERSION_NOT_SUPPORTED = 138;
 const ERR_UNEXPECTED_XML_TYPE = 139;
 const ERR_WRONG_USER_FORMAT_EXTAUTH_PROXY = 140;
+const ERR_TOO_MANY_BATCH_ERRORS = 141;
 
 // Oracle Net layer errors start from 500
 const ERR_CONNECTION_CLOSED = 500;
@@ -403,6 +404,8 @@ messages.set(ERR_UNEXPECTED_XML_TYPE,                   // NJS-139
   'unexpected XML type with flag %d');
 messages.set(ERR_WRONG_USER_FORMAT_EXTAUTH_PROXY,       // NJS-140
   'user name must be enclosed in [] when using external authentication with a proxy user');
+messages.set(ERR_TOO_MANY_BATCH_ERRORS,                 // NJS-141
+  'the number of batch errors from executemany() exceeds 65535');
 
 // Oracle Net layer errors
 
@@ -789,6 +792,7 @@ module.exports = {
   ERR_SERVER_VERSION_NOT_SUPPORTED,
   ERR_UNEXPECTED_XML_TYPE,
   ERR_WRONG_USER_FORMAT_EXTAUTH_PROXY,
+  ERR_TOO_MANY_BATCH_ERRORS,
   ERR_CONNECTION_CLOSED_CODE: `${ERR_PREFIX}-${ERR_CONNECTION_CLOSED}`,
   WRN_COMPILATION_CREATE,
   assert,

lib/thin/protocol/messages/base.js

@@ -90,11 +90,11 @@ class Message {
       buf.skipBytesChunked();
     }
     // batch error codes
-    let numEntries = buf.readUB2();             // batch error codes array
-    if (numEntries > 0) {
+    const numErrors = buf.readUB2();             // batch error codes array
+    if (numErrors > 0) {
       this.errorInfo.batchErrors = [];
       const firstByte = buf.readUInt8();
-      for (let i = 0; i < numEntries; i++) {
+      for (let i = 0; i < numErrors; i++) {
         if (firstByte === constants.TNS_LONG_LENGTH_INDICATOR) {
           buf.skipUB4();                        // chunk length ignored
         }
@@ -107,25 +107,32 @@ class Message {
     }
 
     // batch error offset
-    numEntries = buf.readUB2();                 // batch error row offset array
-    if (numEntries > 0) {
+    const numOffsets = buf.readUB4();           // batch error row offset array
+    if (numOffsets > 0) {
+      if (numOffsets > 65535) {
+        errors.throwErr(errors.ERR_TOO_MANY_BATCH_ERRORS);
+      }
       const firstByte = buf.readUInt8();
-      for (let i = 0; i < numEntries; i++) {
+      let offset;
+      for (let i = 0; i < numOffsets; i++) {
         if (firstByte === constants.TNS_LONG_LENGTH_INDICATOR) {
           buf.skipUB4();                        // chunk length ignored
         }
-        this.errorInfo.batchErrors[i].offset = buf.readUB4();
+        offset = buf.readUB4();
+        if (i < numErrors) {
+          this.errorInfo.batchErrors[i].offset = offset;
+        }
       }
       if (firstByte === constants.TNS_LONG_LENGTH_INDICATOR) {
         buf.skipBytes(1);                       // ignore end marker
       }
     }
 
     // batch error messages
-    numEntries = buf.readUB2();                 // batch error messages array
-    if (numEntries > 0) {
+    const errMsgArr = buf.readUB2();                 // batch error messages array
+    if (errMsgArr > 0) {
       buf.skipBytes(1);                         // ignore packed size
-      for (let i = 0; i < numEntries; i++) {
+      for (let i = 0; i < errMsgArr; i++) {
         buf.skipUB2();                          // skip chunk length
 
         this.errorInfo.batchErrors[i].message = buf.readStr(constants.CSFRM_IMPLICIT);