Fix setting collection element directly. Add VARRAY tests

Author: cjbj

lib/dbObject.js

@@ -61,10 +61,11 @@ const collectionProxyHandler = {
       const index = +prop;
       if (!isNaN(index)) {
         target.setElement(index, value);
-        return;
+        return true;
       }
     }
     target[prop] = value;
+    return true;
   }
 
 };

test/dbObject15.js

@@ -0,0 +1,130 @@
+/* Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved. */
+
+/******************************************************************************
+ *
+ * You may not use the identified files except in compliance with the Apache
+ * License, Version 2.0 (the "License.")
+ *
+ * You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ * NAME
+ *   214. dbObject15.js
+ *
+ * DESCRIPTION
+ *   Test DB Object collection methods.
+ *
+ *****************************************************************************/
+'use strict';
+
+const oracledb  = require('oracledb');
+const should    = require('should');
+const dbconfig  = require('./dbconfig.js');
+
+describe('214. dbObject15.js', () => {
+
+  let conn, FrisbeeTeam;
+
+  const PLAYER_T = 'NODB_TYP_PLAYERTYPE';
+  const TEAM_T   = 'NODB_TYP_TEAMTYPE';
+
+  const FrisbeePlayers = [
+    { SHIRTNUMBER: 10, NAME: 'Emma' },
+    { SHIRTNUMBER: 11, NAME: 'Alex' },
+    { SHIRTNUMBER: 12, NAME: 'Dave' },
+    { SHIRTNUMBER: 13, NAME: 'Jack' },
+    { SHIRTNUMBER: 14, NAME: 'Emmet' }
+  ];
+
+  before(async () => {
+    try {
+      conn = await oracledb.getConnection(dbconfig);
+
+      let plsql =`
+        CREATE OR REPLACE TYPE ${PLAYER_T} AS OBJECT (
+          shirtnumber NUMBER,
+          name        VARCHAR2(20)
+        );
+      `;
+      await conn.execute(plsql);
+
+      plsql =`
+        CREATE OR REPLACE TYPE ${TEAM_T} AS VARRAY(10) OF ${PLAYER_T};
+      `;
+      await conn.execute(plsql);
+
+      const TeamTypeClass = await conn.getDbObjectClass(TEAM_T);
+      FrisbeeTeam = new TeamTypeClass(FrisbeePlayers);
+
+    } catch(err) {
+      should.not.exist(err);
+    }
+  }); // before()
+
+  after(async () => {
+    try {
+
+      let sql = `DROP TYPE ${TEAM_T} FORCE`;
+      await conn.execute(sql);
+
+      sql = `DROP TYPE ${PLAYER_T} FORCE`;
+      await conn.execute(sql);
+
+      await conn.close();
+    } catch(err) {
+      should.not.exist(err);
+    }
+  }); // after()
+
+  it('214.1 Getter() - access collection elements directly', async () => {
+    try {
+
+      for(let i = 0, element; i < FrisbeePlayers.length; i++) {
+        element = FrisbeeTeam[i];
+        should.strictEqual(element.SHIRTNUMBER, FrisbeePlayers[i].SHIRTNUMBER);
+        should.strictEqual(element.NAME, FrisbeePlayers[i].NAME);
+      }
+
+    } catch (err) {
+      should.not.exist(err);
+    }
+  }); // 214.1
+
+  it('214.2 Setter() - access collection element directly', async () => {
+
+    // TypeError: 'set' on proxy: trap returned falsish for property '0'
+    try {
+      const substitute = {SHIRTNUMBER: 15, NAME: 'Chris'};
+      FrisbeeTeam[0] = substitute;
+    } catch (err) {
+      should.not.exist(err);
+    }
+  }); // 214.2
+
+  it('214.3 Negative - delete the collection element directly', async () => {
+    should.throws(
+      function() {
+        delete FrisbeeTeam[1];
+      },
+      /OCI-22164/
+    );
+    // OCI-22164: delete element operation is not allowed for variable-length array
+  }); // 214.3
+
+  it('214.4 Negative - collection.deleteElement()', async () => {
+    should.throws(
+      function() {
+        let firstIndex = FrisbeeTeam.getFirstIndex();
+        FrisbeeTeam.deleteElement(firstIndex);
+      },
+      /OCI-22164/
+    );
+  }); // 214.4
+});

test/list.txt

@@ -4571,4 +4571,10 @@ oracledb.OUT_FORMAT_OBJECT and resultSet =  true
     212.1 examples/plsqlvarrayrecord.js
 
 213. dbObject14.js
-    213.1 examples/selectvarray.js
+    213.1 examples/selectvarray.js
+
+214. dbObject15.js
+    214.1 Getter() - access collection elements directly
+    - 214.2 Setter() - access collection element directly
+    214.3 Negative - delete the collection element directly
+    214.4 Negative - collection.deleteElement()

test/opts/mocha.opts

@@ -237,4 +237,5 @@ test/dbObject10.js
 test/dbObject11.js
 test/dbObject12.js
 test/dbObject13.js
-test/dbObject14.js
+test/dbObject14.js
+test/dbObject15.js