Fixed a crash when selecting multiple rows with LOB values. Another patch by @bjouhier

Author: cjbj

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## node-oracledb v1.2.0 (DD Mon YYYY)
 
+- Fixed a crash when selecting multiple rows with LOB values.
+
 - Added a check to return an NJS error when an invalid DML RETURN statement
   does not give an ORA error.
 

src/njs/src/njsResultSet.cpp

@@ -434,6 +434,24 @@ void ResultSet::Async_GetRows(uv_work_t *req)
       njsRS->fetchRowCount_ = getRowsBaton->numRows;
       njsRS->defineBuffers_ = ebaton->defines;
     }
+    else
+    {
+      for (unsigned int col = 0; col < njsRS->numCols_; col++)
+      {
+        switch(njsRS->meta_[col].dbType)
+        {
+        case dpi::DpiClob:
+        case dpi::DpiBlob:
+        case dpi::DpiBfile:
+          for (unsigned int j = 0; j < ebaton->maxRows; j++)
+          {
+            ((Descriptor **)(njsRS->defineBuffers_[col].buf))[j] =
+              ebaton->dpienv->allocDescriptor(LobDescriptorType);
+          }
+          break;
+        }
+      }
+    }
     ebaton->defines      = njsRS->defineBuffers_;
     Connection::DoFetch(ebaton);