Skip to content

Commit 6b8043a

Browse files
committed
Let's assume that Node.js only bumps the ABI numbers when it bumps Node.js versions
1 parent 456c207 commit 6b8043a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

package/oracledbinstall.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ function done(err, alreadyInstalled) {
378378
} else if (process.arch !== 'x64') {
379379
packageUtil.error('Pre-built binary packages are not available for architecture="' + process.arch + '"');
380380
} else if (['48', '57', '64'].indexOf(process.versions.modules) < 0) {
381-
packageUtil.error('Pre-built binary packages are not available for this version of Node.js (NODE_MODULE_VERSION="' + process.versions.modules + '")');
381+
packageUtil.error('Pre-built binary packages are not available for Node.js ' + process.version + ' (NODE_MODULE_VERSION="' + process.versions.modules + '")');
382382
}
383383
packageUtil.error('Failed to install binary package ' + packageUtil.dynamicProps.PACKAGE_FILE_NAME);
384384
packageUtil.error(err.message);
@@ -454,8 +454,8 @@ function install() {
454454

455455
const nodeMajorVersion = Number(process.version.split('.')[0].replace(/^v/, ''));
456456

457-
if (!nodeMajorVersion >= 4) {
458-
done(new Error('Node.js v4.0.0 or higher is required to install from binary'));
457+
if (!nodeMajorVersion >= 6) {
458+
done(new Error('Node.js v6.0.0 or higher is required to install pre-built binaries'));
459459
return;
460460
}
461461

0 commit comments

Comments
 (0)