Tests for RS and LOB automatically close after conn closes

Author: cjbj

test/connection.js

@@ -798,8 +798,10 @@ describe('1. connection.js', function(){
           connectString: 'this is wrong',
           connectionString: dbConfig.connectString
         },
-        function(err, connection) {
+        function(err, conn) {
           should.exist(err);
+          // ORA-12154: TNS:could not resolve the connect identifier specified
+          should.not.exist(conn);
 
           oracledb.getConnection(
             {

test/list.txt

@@ -70,7 +70,7 @@ Overview of node-oracledb functional tests
         2.10.1 close can be used as an alternative to release
     2.11 Invalid Credential
         2.11.1 error occurs at creating pool when poolMin >= 1
-        2.11.2 error occurs at getConnection() when poolMin is the default value 1
+        2.11.2 error occurs at getConnection() when poolMin is the default value 0
     2.12 connectionString alias
         2.12.1 allows connectionString to be used as an alias for connectString
         2.12.2 favors connectString if both connectString and connectionString are passed
@@ -824,6 +824,7 @@ Overview of node-oracledb functional tests
     54.1 can access properties of closed LOB without error
     54.2 can not call close() multiple times
     54.3 verify closed LOB
+    54.4 automatically close result sets and LOBs when the connection is closed
 
 55. resultSet2.js
     55.1 query a RDBMS function
@@ -833,9 +834,9 @@ Overview of node-oracledb functional tests
     55.3 alternating getRow() & getRows() function
         55.3.1 result set
         55.3.2 REF Cursor
-    55.4 release connection before close resultSet
-        55.4.1 result set
-        55.4.2 REF Cursor
+    55.4 automatically close result sets and LOBs when the connection is closed
+        55.4.1 resultSet gets closed automatically
+        55.4.2 REF Cursor gets closed automatically
     55.5 the content of resultSet should be consistent
         55.5.1 (1) get RS (2) modify data in that table and commit (3) check RS
     55.6 access resultSet simultaneously

test/lobClose.js

@@ -1,4 +1,4 @@
-/* Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. */
+/* Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights reserved. */
 
 /******************************************************************************
  *
@@ -37,6 +37,7 @@ var oracledb = require('oracledb');
 var should   = require('should');
 var dbConfig = require('./dbconfig.js');
 var fs       = require('fs');
+var async    = require('async');
 
 describe('54. lobClose.js', function() {
 
@@ -124,7 +125,6 @@ describe('54. lobClose.js', function() {
           });
 
           lob.on("error", function(err) {
-            //should.not.exist(err, "lob.on 'error' event.");
             should.strictEqual(
               err.message,
               "NJS-022: invalid Lob"
@@ -141,4 +141,64 @@ describe('54. lobClose.js', function() {
     );
   }); // 54.3
 
+  it('54.4 automatically close result sets and LOBs when the connection is closed', function(done) {
+
+    var conn2 = null;
+    var lob2 = null;
+    async.series([
+      function creatConn(cb) {
+        oracledb.getConnection(
+          dbConfig,
+          function(err, connection) {
+            should.not.exist(err);
+            conn2 = connection;
+            cb();
+          }
+        );
+      },
+      function createLOB(cb) {
+        conn2.createLob(
+          oracledb.CLOB,
+          function(err, lob) {
+            should.not.exist(err);
+            lob2 = lob;
+            cb();
+          }
+        );
+      },
+      function closeConn(cb) {
+        conn2.close(cb);
+      },
+      function dotest(cb) {
+      // Verify that lob2 gets closed automatically
+        var inFileName = './test/clobexample.txt';
+        var inStream = fs.createReadStream(inFileName);
+        inStream.pipe(lob2);
+
+        inStream.on("error", function(err) {
+          should.not.exist(err, "inStream.on 'error' event.");
+        });
+
+        lob2.on("error", function(err) {
+          should.strictEqual(
+            err.message,
+            "DPI-1040: LOB was already closed"
+          );
+          cb();
+        });
+
+        lob2.on('finish', function() {
+          cb(new Error("LOB emits 'finish' event!"));
+        });
+      },
+      function(cb) {
+        (lob2.chunkSize).should.be.a.Number();
+        (lob2.pieceSize).should.be.a.Number();
+        should.strictEqual(lob2.length, 0);
+        should.strictEqual(lob2.type, oracledb.CLOB);
+        cb();
+      }
+    ], done);
+  }); // 54.4
+
 });

test/pool.js

@@ -1010,7 +1010,7 @@ describe('2. pool.js', function() {
       );
     }); // 2.11.1
 
-    it('2.11.2 error occurs at getConnection() when poolMin is the default value 1', function(done) {
+    it('2.11.2 error occurs at getConnection() when poolMin is the default value 0', function(done) {
       oracledb.createPool(
         {
           user: 'notexist',
@@ -1075,6 +1075,7 @@ describe('2. pool.js', function() {
         },
         function(err, pool) {
           should.exist(err);
+          should.not.exist(pool);
 
           oracledb.createPool(
             {

test/resultSet2.js

@@ -1,4 +1,4 @@
-/* Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved. */
+/* Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights reserved. */
 
 /******************************************************************************
  *
@@ -262,7 +262,7 @@ describe('55. resultSet2.js', function() {
     });
   });
 
-  describe('55.4 release connection before close resultSet', function() {
+  describe('55.4 automatically close result sets and LOBs when the connection is closed', function() {
     before(function(done){
       setUp(connection, tableName, done);
     });
@@ -304,7 +304,7 @@ describe('55. resultSet2.js', function() {
       });
     }
 
-    it('55.4.1 result set', function(done) {
+    it('55.4.1 resultSet gets closed automatically', function(done) {
       testConn.should.be.ok();
       testConn.execute(
         "SELECT * FROM nodb_rs2_emp ORDER BY employees_id",
@@ -317,7 +317,7 @@ describe('55. resultSet2.js', function() {
       );
     });
 
-    it('55.4.2 REF Cursor', function(done) {
+    it('55.4.2 REF Cursor gets closed automatically', function(done) {
       testConn.should.be.ok();
       testConn.execute(
         "BEGIN nodb_rs2_get_emp(:in, :out); END;",
@@ -873,6 +873,7 @@ describe('55. resultSet2.js', function() {
         },
         function ( err ) {
           should.exist ( err );
+          // ORA-24338: statement handle not executed
           done();
         }
       );

test/v8Getter.js

@@ -544,7 +544,14 @@ describe('140. v8Getter.js', function() {
           throw 'Nope';
         }
       });
-      dotest(cred, done);
+
+      should.throws(
+        function() {
+          oracledb.createPool(cred, function() {});
+        },
+        /Nope/
+      );
+      done();
     });
 
     it('140.7.4 poolMin', function(done) {