Fixed bug where NJS-112 internal error was thrown intermittently and incorrectly

Author: sharadraju

doc/src/release_notes.rst

@@ -20,6 +20,8 @@ Thin Mode Changes
 #)  Improve error message when an internal error handler fails and a connection
     is no longer usable.
 
+#)  Fixed bug where NJS-112 is thrown intermittently with some connections. 
+
 node-oracledb `v6.0.2 <https://github.com/oracle/node-oracledb/compare/v6.0.1...v6.0.2>`__ (27 Jun 2023)
 --------------------------------------------------------------------------------------------------------
 

lib/thin/protocol/messages/base.js

@@ -230,8 +230,8 @@ class Message {
      || (opcode === constants.TNS_SERVER_PIGGYBACK_TRACE_EVENT)) {
       // pass
     } else if (opcode === constants.TNS_SERVER_PIGGYBACK_OS_PID_MTS) {
-      const nb = buf.readUB2();
-      buf.skipBytes(nb + 1);
+      buf.skipUB2();
+      buf.skipBytesChunked();
     } else if (opcode === constants.TNS_SERVER_PIGGYBACK_SYNC) {
       buf.skipUB2();                            // skip number of DTYs
       buf.skipUB1();                            // skip length of DTYs
@@ -240,11 +240,11 @@ class Message {
       for (let i = 0; i < num_elements; i++) {
         let temp16 = buf.readUB2();
         if (temp16 > 0) {                       // skip key
-          buf.skipBytes(temp16 + 1);
+          buf.skipBytesChunked();
         }
         temp16 = buf.readUB2();
         if (temp16 > 0) {                       // skip value
-          buf.skipBytes(temp16 + 1);
+          buf.skipBytesChunked();
         }
         buf.skipUB2();                          // skip flags
         buf.skipUB4();                          // skip overall flags
@@ -271,11 +271,11 @@ class Message {
         for (let i = 0; i < num_elements; ++i) {
           let temp16 = buf.readUB2();
           if (temp16 > 0) {                     // skip key
-            buf.skipBytes(temp16 + 1);
+            buf.skipBytesChunked();
           }
           temp16 = buf.readUB2();
           if (temp16 > 0) {                     // skip value
-            buf.skipBytes(temp16 + 1);
+            buf.skipBytesChunked();
           }
           buf.skipUB2();                        // skip flags
         }

lib/thin/protocol/messages/withData.js

@@ -139,15 +139,15 @@ class MessageWithData extends Message {
 
     let numBytes = buf.readUB4();
     if (numBytes > 0) {
-      buf.skipBytes(numBytes + 1);              // current date
+      buf.skipBytesChunked();                   // current date
     }
     buf.skipUB4();                              // dcbflag
     buf.skipUB4();                              // dcbmdbz
     buf.skipUB4();                              // dcbmnpr
     buf.skipUB4();                              // dcbmxpr
     numBytes = buf.readUB4();
     if (numBytes > 0) {
-      buf.skipBytes(numBytes + 1);
+      buf.skipBytesChunked();
     }
 
     this.resultSetsToSetup.push(resultSet);